test: relocate Apple engine unit tests into platforms/apple/core (#980)#983
Merged
Conversation
…s/apple/core (#980) After #968 moved the OS-agnostic Apple engine to src/platforms/apple/core/, its tests still lived in src/platforms/ios/__tests__/. Move the 19 that test Apple engine code into src/platforms/apple/core/__tests__/ so tests sit beside their source, re-relativizing every import / dynamic import / vi.mock / vi.importActual specifier to the new depth. Deferred (still in src/platforms/ios/__tests__/): recording-scripts.test.ts and runner-client.test.ts — both compute runtime fs paths (__dirname / fileURLToPath) to ios-runner artifacts, so they need path-string fixes, not just specifier re-relativization. Tracked under #980. Pure test relocation — no source or behavior change. tsc + oxlint + oxfmt green; the moved suites pass (384 tests across the apple + deferred dirs).
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Review pass for head 5060630 found no actionable blockers. Checked against cleanup issue #980: this PR mechanically relocates the Apple engine unit tests beside src/platforms/apple/core and re-relativizes static imports, dynamic imports, vi.mock, and vi.importActual specifiers. It intentionally leaves the fs-path-sensitive deferred tests in src/platforms/ios/tests, matching the issue notes. All reported checks are green. |
thymikee
added
the
ready-for-human
|
This was referenced Jul 1, 2026
thymikee
added a commit
that referenced
this pull request
Jul 1, 2026
…) (#988) Completes the #983 relocation. The 2 files deferred there compute runtime fs paths (fileURLToPath/__dirname), so they needed path-depth fixes on top of import re-relativization: - runner-client.test.ts -> src/platforms/apple/core/__tests__/ (joins the rest of the Apple engine tests); repoRoot recomputed one level deeper. - recording-scripts.test.ts -> src/recording/__tests__/ (beside the overlay.ts it tests); ios-runner RecordingScripts + test/integration/support paths recomputed one level shallower. src/platforms/ios/__tests__/ is now empty (all Apple-engine tests live beside their source under apple/core and recording). Pure test relocation — tsc, oxlint, oxfmt, layering guard, fallow green; full unit suite passes (2883).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #968 (cleanup issue #980): after the Apple engine moved to
src/platforms/apple/core/, its unit tests still lived insrc/platforms/ios/__tests__/. This relocates the tests beside their source.src/platforms/ios/__tests__/ → src/platforms/apple/core/__tests__/(the runner stack, discovery, tool-provider, screenshot/perf, debug-symbols, plist/xml, apple-runner-platform, launch-diagnostics, simctl, the mixedindex.test.ts, and themacos-helper-test-utilshelper).from/import/ dynamicimport()/vi.mock/vi.importActualspecifier to the new depth (including thevi.importActual<typeof import('…')>('…')runtime args).Deferred (still in
src/platforms/ios/__tests__/)recording-scripts.test.tsandrunner-client.test.ts— both compute runtime fs paths (__dirname/fileURLToPath) toios-runnerartifacts, so they need path-string fixes, not just specifier re-relativization. Left for a focused follow-up under #980.Verification
Pure test relocation — no source or behavior change. Local:
tscclean,oxlint --deny-warningsclean,oxfmt --checkclean; the moved suites pass (384 tests across the apple/core + deferred dirs). The 3 AndroidfillAndroidfull-suite failures are the pre-existing CPU-contention flake (pass in isolation; this PR does not touch Android).Part of #980.