test: relocate the 2 deferred Apple runner/recording tests (closes #980)#988
Merged
Conversation
Completes the #983 relocation. The 2 files deferred there compute runtime fs paths (fileURLToPath/__dirname), so they needed path-depth fixes on top of import re-relativization: - runner-client.test.ts -> src/platforms/apple/core/__tests__/ (joins the rest of the Apple engine tests); repoRoot recomputed one level deeper. - recording-scripts.test.ts -> src/recording/__tests__/ (beside the overlay.ts it tests); ios-runner RecordingScripts + test/integration/support paths recomputed one level shallower. src/platforms/ios/__tests__/ is now empty (all Apple-engine tests live beside their source under apple/core and recording). Pure test relocation — tsc, oxlint, oxfmt, layering guard, fallow green; full unit suite passes (2883).
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
|
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes cleanup issue #980 (follow-up to #983). #983 relocated 19/21 Apple-engine unit tests; the 2 deferred here compute runtime fs paths (
fileURLToPath/__dirname), so they needed path-depth fixes in addition to import re-relativization.runner-client.test.ts→src/platforms/apple/core/__tests__/(joins the other Apple engine tests);repoRootrecomputed one level deeper (../../../../→../../../../../),vi.mock/vi.importActual/imports re-relativized.recording-scripts.test.ts→src/recording/__tests__/(beside theoverlay.tsit tests); theios-runner/…/RecordingScripts+test/integration/support__dirname-relative paths recomputed one level shallower.src/platforms/ios/__tests__/is now empty — every Apple-engine test sits beside its source underapple/core/(andsrc/recording/for the recording-overlay test).Verification
Pure test relocation — no source/behavior change. Local:
tsc,oxlint --deny-warnings,oxfmt --check, the layering guard, andfallow auditall clean; full unit suite passes (2883). The moved suites pass (64 tests) including the runtime-path assertions.Closes #980.