test: relocate remaining Apple-engine unit tests to apple/core (#980)#989
Closed
thymikee wants to merge 1 commit into
Closed
test: relocate remaining Apple-engine unit tests to apple/core (#980)#989thymikee wants to merge 1 commit into
thymikee wants to merge 1 commit into
Conversation
Finishes the relocation started in #983, which moved 19 Apple-engine unit tests into src/platforms/apple/core/__tests__/ but deferred two files that compute runtime fs paths to native runner artifacts. Moves the last two: - recording-scripts.test.ts - runner-client.test.ts Both needed the relative import specifiers re-relativized for the deeper location, plus one extra `../` on the runtime fs paths that resolve against the repo root (the native ios-runner/ project and test/integration/support still live at the repo root; #968 only moved the TypeScript engine): - recording-scripts.test.ts: recordingScriptsDir / recordingTestSupportDir (`../../../../` -> `../../../../../`) -> ios-runner/.../RecordingScripts and test/integration/support. - runner-client.test.ts: repoRoot (`../../../../` -> `../../../../../`), which feeds the project `.tmp` dir and the ios-runner xcodeproj path. Behaviorless move. Verified: tsc --noEmit clean, both test files pass (64 tests), layering check OK, oxfmt/oxlint clean, fallow audit clean. closes #980
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finishes the Apple-engine unit-test relocation under Phase-3 umbrella #972. PR #983 moved 19 tests from
src/platforms/ios/__tests__/intosrc/platforms/apple/core/__tests__/but deferred 2 files because they compute runtime fs paths to native runner artifacts (not just import re-relativization). This PR moves the last two:recording-scripts.test.tsrunner-client.test.tsPath fixes made
Both files moved one directory level deeper (
platforms/ios/__tests__→platforms/apple/core/__tests__), so both relative import specifiers and repo-root-relative runtime fs paths gained one../level.Import re-relativization:
../../../<src-dir>/…→../../../../<src-dir>/…(utils, kernel, daemon, recording)../../apple/core/runner/…→../runner/…(sibling runner modules)Runtime fs path fixes (the reason these were deferred): the native
ios-runner/Xcode project andtest/integration/support/still live at the repo root — #968 only consolidated the TypeScript engine intoplatforms/apple/, not the Swift runner sources. So the repo-root-relative paths needed one extra../:recording-scripts.test.ts:recordingScriptsDirandrecordingTestSupportDir(../../../../→../../../../../) → resolve toios-runner/AgentDeviceRunner/RecordingScriptsandtest/integration/support.runner-client.test.ts:repoRoot(../../../../→../../../../../), which feeds the project.tmpdir and theios-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeprojpath. All otherios-runnerstring occurrences in this file are synthetic temp-dir fixtures / regex assertions and were left untouched.Behaviorless move — no test logic changed (oxfmt reflowed the import wrapping).
Verification
tsc -p tsconfig.json --noEmit— cleanvitest runboth moved files — 2 files, 64 tests passscripts/layering/check.ts— OK (635 files satisfy the DAG)oxfmt --write+oxlint --deny-warningson changed — cleanfallow audit --base origin/main— no issues in changed filescloses #980