Skip to content

aria2-openssl: Add OpenSSL build for TLS 1.3 support#2828

Closed
B67687 wants to merge 7 commits intoScoopInstaller:masterfrom
B67687:aria2-openssl
Closed

aria2-openssl: Add OpenSSL build for TLS 1.3 support#2828
B67687 wants to merge 7 commits intoScoopInstaller:masterfrom
B67687:aria2-openssl

Conversation

@B67687
Copy link
Copy Markdown
Contributor

@B67687 B67687 commented May 1, 2026

Summary

Add aria2-openssl to the Versions bucket as an OpenSSL-linked aria2 build for users who need TLS 1.3 support.

Problem

The default aria2 setup in Scoop relies on Windows TLS (Schannel). On Windows 10 and older Windows Server versions, that can fail against TLS 1.3-only endpoints.

Solution

Provide an OpenSSL-linked aria2 package in the Versions bucket.

Usage

scoop install aria2-openssl
scoop config aria2-path "$(scoop prefix aria2-openssl)\aria2c.exe"

Relates to ScoopInstaller/Extras#17010.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Walkthrough

Adds a new Scoop package manifest aria2-openssl (v1.37.0) for 64-bit Windows that registers aria2c.exe, provides the GitHub release download URL and SHA-256, and configures checkver and autoupdate for releases.

Changes

Cohort / File(s) Summary
aria2-openssl Package Manifest
bucket/aria2-openssl.json
Adds new Scoop manifest for aria2-openssl v1.37.0: sets bin to aria2c.exe, specifies release download URL and SHA-256, configures checkver to extract v([\d.]+) from GitHub tag_name, and provides an autoupdate URL template.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I'm a rabbit in a tidy patch,
I found a manifest and fixed the latch,
aria2c dressed with OpenSSL bright,
I hopped the bytes into the night,
🐇📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding an OpenSSL-linked aria2 build for TLS 1.3 support, which is the primary objective of this PR.
Linked Issues check ✅ Passed The PR successfully addresses the objective from issue #17010 by providing an OpenSSL-linked aria2 build to support TLS 1.3 on older Windows versions, enabling downloads from TLS 1.3-only servers like tutanota.
Out of Scope Changes check ✅ Passed All changes are within scope: the new bucket/aria2-openssl.json manifest directly implements the solution specified in issue #17010 with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description is comprehensive, follows the template structure with PR title convention, includes problem/solution/usage, and references a related issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 1, 2026

This fix was inspired from tutanota not being able to use aria2 properly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/aria2-openssl.json`:
- Around line 15-16: Add a `depends` entry that includes the `cacert` package to
ensure CA certificates are available (mirror how `wget120.json` wires `cacert`),
and update the informational string that currently reads "IMPORTANT: Requires CA
certificates for HTTPS. Use --check-certificate=false if needed." to instead
instruct users to install `cacert` and remove the recommendation to disable
certificate verification (you may mention disabling `--check-certificate=false`
only as a last-resort temporary debugging step). Target the manifest's metadata
strings and the `depends` field in this JSON (look for the existing "IMPORTANT:
Requires CA certificates..." text and add/modify the `"depends"` array
accordingly).
- Line 5: The manifest's version "1.37.0-1" conflicts with checkver.regex
"v([\\d.]+)" which only captures "1.37.0" causing the "-1" build suffix to be
lost; update checkver.regex (in the checkver block) to capture optional build
suffixes (e.g., allow hyphens and digits/patch parts such as using a pattern
that accepts [\\d.-]+) so the full "1.37.0-1" is preserved, and ensure the
autoupdate/url templating still works with the captured group. Also remove the
insecure fallback that suggests "--check-certificate=false" from the notes and
replace it with guidance to install a CA bundle or rely on the system CA store
(or add a manifest dependency on a CA bundle package) so users are directed to
secure TLS certificate validation instead.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8809200-7432-453e-9ce7-89e7c8050c6e

📥 Commits

Reviewing files that changed from the base of the PR and between effd8dc and 7751bad.

📒 Files selected for processing (1)
  • bucket/aria2-openssl.json

Comment thread bucket/aria2-openssl.json Outdated
Comment thread bucket/aria2-openssl.json Outdated
This version uses OpenSSL instead of Windows TLS (Schannel).

Problem: The default aria2 in main bucket uses Windows TLS (Schannel),
which doesn't support TLS 1.3 on Windows 10 or older Windows Server
versions. Only Windows 11 21H2+ and Windows Server 2022+ support it.

Affected servers: Tuta (tutanota), some CloudFlare configurations,
and any server with TLS 1.3-only configuration.

Solution: Add this OpenSSL-linked build for users who need TLS 1.3.

Usage:
  scoop install aria2-openssl
  scoop config aria2-path '$env:USERPROFILE\scoop\apps\aria2-openssl\current\aria2c.exe'

Closes: ScoopInstaller/Extras#17010
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

aria2-openssl

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 2, 2026

Closing this because the current manifest depends on a third-party prebuilt binary. Official aria2 does publish Windows binaries, but they are not OpenSSL-linked, so switching to official upstream would not achieve the goal of this package.

Considering requesting upstream for official support of TLS 1.3 on aria2

@B67687 B67687 closed this May 2, 2026
@B67687 B67687 deleted the aria2-openssl branch May 2, 2026 23:37
@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 4, 2026

Retested this on May 4, 2026, and the current Scoop install flow works with stock aria2.

The likely fix point is in Extras, not Versions: ScoopInstaller/Extras@280b9ee (tutanota: Update to version 346.260428.0, fix autoupdate) changed the manifest download URL from https://app.tuta.com/desktop/tutanota-desktop-win.exe#/dl.7z to the GitHub releases URL.

The related PR is #17704

Fresh verification from a clean state:

  • scoop install aria2
  • scoop install tutanota -s
  • direct aria2c --dry-run against the current manifest URL

All three succeeded here. So for the current manifest, this no longer appears to require an OpenSSL-linked aria2 package.

If anyone hits the old failure again, I’d first make sure they are on the current Extras manifest and retest after reinstalling aria2 and tutanota, rather than assuming the old app.tuta.com / TLS 1.3 path still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant