Skip to content

tutanota: Add note about TLS 1.3 workaround#17723

Closed
B67687 wants to merge 5 commits intoScoopInstaller:masterfrom
B67687:tutanota-tls-note
Closed

tutanota: Add note about TLS 1.3 workaround#17723
B67687 wants to merge 5 commits intoScoopInstaller:masterfrom
B67687:tutanota-tls-note

Conversation

@B67687
Copy link
Copy Markdown
Contributor

@B67687 B67687 commented May 1, 2026

Summary

Add a note to the tutanota manifest explaining the TLS 1.3 download issue on older Windows systems and an immediate workaround that works today.

Details

Tuta download endpoints require TLS 1.3. On Windows 10 and some older Windows Server versions, the default aria2 setup can fail when using Schannel.

This note points users to the immediate workaround that already works:

scoop install tutanota -a

Relates to #17010.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

📝 Walkthrough

Walkthrough

A single-line notes property was added to bucket/tutanota.json. The notes document a Windows 10 SSL/TLS download failure workaround that suggests retrying downloads without aria2, and states an OpenSSL-linked aria2 build is being prepared for future use. No other manifest fields or runtime logic were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a note about a TLS 1.3 workaround to the tutanota manifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description includes a clear summary, detailed explanation of the TLS 1.3 issue, the workaround command, and confirms adherence to the contributing guide and conventional commit format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/tutanota.json (1)

5-5: 💤 Low value

Informational: Deprecated SPDX license identifier (existing code).

The license field uses the deprecated bare identifier GPL-3.0. While this is not part of your PR changes, consider updating it in a future commit to use the modern SPDX format: either GPL-3.0-only or GPL-3.0-or-later (depending on the project's license terms).

Based on learnings, GitHub's license API may return deprecated identifiers, so always verify with the project's actual license file to determine the correct suffixed variant.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/tutanota.json` at line 5, The SPDX identifier "GPL-3.0" in the JSON
should be updated to a modern, explicit form; decide whether the project intends
"GPL-3.0-only" or "GPL-3.0-or-later" (verify LICENSE file), then replace the
value for the "license" key in tutanota.json accordingly so the file uses the
correct suffixed SPDX identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/tutanota.json`:
- Line 20: The notes entry currently hardcodes the Scoop path
($env:USERPROFILE\scoop) which fails for non-default installs; update the
"notes" field to use scoop's dynamic prefix resolution (e.g., use `scoop prefix
aria2-openssl` to locate the aria2-openssl install and reference its
current\aria2c.exe) instead of the hardcoded path so the suggested commands work
for global or custom Scoop installations; modify the string in the "notes" field
(the JSON key "notes") to show the install and config commands using scoop
prefix resolution.

---

Nitpick comments:
In `@bucket/tutanota.json`:
- Line 5: The SPDX identifier "GPL-3.0" in the JSON should be updated to a
modern, explicit form; decide whether the project intends "GPL-3.0-only" or
"GPL-3.0-or-later" (verify LICENSE file), then replace the value for the
"license" key in tutanota.json accordingly so the file uses the correct suffixed
SPDX identifier.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 206dbdf4-d01d-4c4f-8875-90f6f5ec863f

📥 Commits

Reviewing files that changed from the base of the PR and between feaebf6 and f4960cc.

📒 Files selected for processing (1)
  • bucket/tutanota.json

Comment thread bucket/tutanota.json Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

tutanota

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All changes look good.

Wait for review from human collaborators.

tutanota

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 2, 2026

Temporarily closing this until aria2 supports tls 1.3 officially

Refer to ScoopInstaller/Versions#2828 (comment) as the problem is already solved

@B67687 B67687 closed this May 2, 2026
@z-Fng z-Fng added invalid This doesn't seem right. and removed review-needed labels May 2, 2026
@B67687 B67687 deleted the tutanota-tls-note branch May 2, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants