tutanota: Add note about TLS 1.3 workaround#17723
tutanota: Add note about TLS 1.3 workaround#17723B67687 wants to merge 5 commits intoScoopInstaller:masterfrom
Conversation
📝 WalkthroughWalkthroughA single-line Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/tutanota.json (1)
5-5: 💤 Low valueInformational: Deprecated SPDX license identifier (existing code).
The license field uses the deprecated bare identifier
GPL-3.0. While this is not part of your PR changes, consider updating it in a future commit to use the modern SPDX format: eitherGPL-3.0-onlyorGPL-3.0-or-later(depending on the project's license terms).Based on learnings, GitHub's license API may return deprecated identifiers, so always verify with the project's actual license file to determine the correct suffixed variant.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tutanota.json` at line 5, The SPDX identifier "GPL-3.0" in the JSON should be updated to a modern, explicit form; decide whether the project intends "GPL-3.0-only" or "GPL-3.0-or-later" (verify LICENSE file), then replace the value for the "license" key in tutanota.json accordingly so the file uses the correct suffixed SPDX identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/tutanota.json`:
- Line 20: The notes entry currently hardcodes the Scoop path
($env:USERPROFILE\scoop) which fails for non-default installs; update the
"notes" field to use scoop's dynamic prefix resolution (e.g., use `scoop prefix
aria2-openssl` to locate the aria2-openssl install and reference its
current\aria2c.exe) instead of the hardcoded path so the suggested commands work
for global or custom Scoop installations; modify the string in the "notes" field
(the JSON key "notes") to show the install and config commands using scoop
prefix resolution.
---
Nitpick comments:
In `@bucket/tutanota.json`:
- Line 5: The SPDX identifier "GPL-3.0" in the JSON should be updated to a
modern, explicit form; decide whether the project intends "GPL-3.0-only" or
"GPL-3.0-or-later" (verify LICENSE file), then replace the value for the
"license" key in tutanota.json accordingly so the file uses the correct suffixed
SPDX identifier.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 206dbdf4-d01d-4c4f-8875-90f6f5ec863f
📒 Files selected for processing (1)
bucket/tutanota.json
|
All changes look good. Wait for review from human collaborators. tutanota
|
|
All changes look good. Wait for review from human collaborators. tutanota
|
|
Refer to ScoopInstaller/Versions#2828 (comment) as the problem is already solved |
Summary
Add a note to the
tutanotamanifest explaining the TLS 1.3 download issue on older Windows systems and an immediate workaround that works today.Details
Tuta download endpoints require TLS 1.3. On Windows 10 and some older Windows Server versions, the default
aria2setup can fail when using Schannel.This note points users to the immediate workaround that already works:
scoop install tutanota -aRelates to #17010.
<manifest-name[@version]|chore>: <general summary of the pull request>