tutanota: Add note about TLS 1.3 workaround#17721
tutanota: Add note about TLS 1.3 workaround#17721B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 5/8 reviews remaining, refill in 15 minutes and 37 seconds.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
bucket/tutanota.json (2)
20-20: Please include local manifest validation steps in PR testing notes.Suggested commands:
.\bin\checkver.ps1 -App tutanota -f.\bin\formatjson.ps1 -App tutanotascoop install .\bucket\tutanota.json -a 64bitAs per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tutanota.json` at line 20, The PR is missing local manifest validation steps in the tutanota manifest notes; update the "notes" entry in bucket/tutanota.json (the notes field shown in the diff) to include the three suggested local testing commands and brief guidance: run .\bin\checkver.ps1 -App tutanota -f to validate version, .\bin\formatjson.ps1 -App tutanota to format the manifest, and scoop install .\bucket\tutanota.json -a 64bit to test installation locally; ensure the notes string clearly lists these steps so reviewers can reproduce local validation.
20-20: Usescoop prefix aria2-opensslinstead of hardcoding the Scoop root path.The hardcoded path
"$env:USERPROFILE\scoop\apps\..."breaks for users who configure a non-default Scoop root. Instead, guide users to runscoop prefix aria2-opensslto get the correct path dynamically for their installation:"notes": "If download fails with TLS 1.3 error on Windows 10, install aria2-openssl and configure: `scoop install aria2-openssl; scoop config aria2-path \"$(scoop prefix aria2-openssl)\\aria2c.exe\"`",This works for all Scoop root configurations.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/tutanota.json` at line 20, Update the "notes" value that currently hardcodes the Scoop root path ("$env:USERPROFILE\\scoop\\apps\\aria2-openssl\\current\\aria2c.exe") to use Scoop's dynamic prefix resolution instead; instruct users to run `scoop install aria2-openssl` and set the aria2-path using `$(scoop prefix aria2-openssl)\\aria2c.exe` so non-default Scoop roots work (refer to the "notes" key in tutanota.json to locate and update the string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/tutanota.json`:
- Line 20: The PR is missing local manifest validation steps in the tutanota
manifest notes; update the "notes" entry in bucket/tutanota.json (the notes
field shown in the diff) to include the three suggested local testing commands
and brief guidance: run .\bin\checkver.ps1 -App tutanota -f to validate version,
.\bin\formatjson.ps1 -App tutanota to format the manifest, and scoop install
.\bucket\tutanota.json -a 64bit to test installation locally; ensure the notes
string clearly lists these steps so reviewers can reproduce local validation.
- Line 20: Update the "notes" value that currently hardcodes the Scoop root path
("$env:USERPROFILE\\scoop\\apps\\aria2-openssl\\current\\aria2c.exe") to use
Scoop's dynamic prefix resolution instead; instruct users to run `scoop install
aria2-openssl` and set the aria2-path using `$(scoop prefix
aria2-openssl)\\aria2c.exe` so non-default Scoop roots work (refer to the
"notes" key in tutanota.json to locate and update the string).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c1939967-0622-47cb-9e01-062ce692e888
📒 Files selected for processing (1)
bucket/tutanota.json
|
Closing this PR - replaced by #17723 which uses the immediate workaround |
Summary
Add a note to the manifest explaining the TLS 1.3 download issue on older Windows systems and an immediate workaround that works today.
Details
Tuta download endpoints require TLS 1.3. On Windows 10 and some older Windows Server versions, the default setup can fail when using Schannel.
This note now points users to:
scoop install tutanota -aas the immediate workaround, while still leaving room for an OpenSSL-linked
aria2option later.Related: ScoopInstaller/Versions#2828