Skip to content

tutanota: Add note about TLS 1.3 workaround#17721

Closed
B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
B67687:tutanota-tls-note
Closed

tutanota: Add note about TLS 1.3 workaround#17721
B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
B67687:tutanota-tls-note

Conversation

@B67687
Copy link
Copy Markdown
Contributor

@B67687 B67687 commented May 1, 2026

Summary

Add a note to the manifest explaining the TLS 1.3 download issue on older Windows systems and an immediate workaround that works today.

Details

Tuta download endpoints require TLS 1.3. On Windows 10 and some older Windows Server versions, the default setup can fail when using Schannel.

This note now points users to:

scoop install tutanota -a

as the immediate workaround, while still leaving room for an OpenSSL-linked aria2 option later.


Related: ScoopInstaller/Versions#2828

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 57a43b92-127d-420a-98d3-ef5eb54cb732

📥 Commits

Reviewing files that changed from the base of the PR and between e795354 and e28da67.

📒 Files selected for processing (1)
  • bucket/tutanota.json
✅ Files skipped from review due to trivial changes (1)
  • bucket/tutanota.json

📝 Walkthrough

Walkthrough

A notes array was added to bucket/tutanota.json with two entries: (1) instructs rerunning the download using scoop install tutanota -a if aria2 fails due to TLS 1.3 on Windows 10; (2) states that an OpenSSL-linked aria2 client will be usable from the buckets once available, allowing an OpenSSL-enabled aria2c.exe to be used for downloads.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a note about a TLS 1.3 workaround to the tutanota manifest.
Description check ✅ Passed The description clearly explains the problem, solution, and provides relevant context. However, the conventional commit format check is marked as complete when the title only partially follows the format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 5/8 reviews remaining, refill in 15 minutes and 37 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
bucket/tutanota.json (2)

20-20: Please include local manifest validation steps in PR testing notes.

Suggested commands:

  • .\bin\checkver.ps1 -App tutanota -f
  • .\bin\formatjson.ps1 -App tutanota
  • scoop install .\bucket\tutanota.json -a 64bit

As per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/tutanota.json` at line 20, The PR is missing local manifest validation
steps in the tutanota manifest notes; update the "notes" entry in
bucket/tutanota.json (the notes field shown in the diff) to include the three
suggested local testing commands and brief guidance: run .\bin\checkver.ps1 -App
tutanota -f to validate version, .\bin\formatjson.ps1 -App tutanota to format
the manifest, and scoop install .\bucket\tutanota.json -a 64bit to test
installation locally; ensure the notes string clearly lists these steps so
reviewers can reproduce local validation.

20-20: Use scoop prefix aria2-openssl instead of hardcoding the Scoop root path.

The hardcoded path "$env:USERPROFILE\scoop\apps\..." breaks for users who configure a non-default Scoop root. Instead, guide users to run scoop prefix aria2-openssl to get the correct path dynamically for their installation:

"notes": "If download fails with TLS 1.3 error on Windows 10, install aria2-openssl and configure: `scoop install aria2-openssl; scoop config aria2-path \"$(scoop prefix aria2-openssl)\\aria2c.exe\"`",

This works for all Scoop root configurations.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/tutanota.json` at line 20, Update the "notes" value that currently
hardcodes the Scoop root path
("$env:USERPROFILE\\scoop\\apps\\aria2-openssl\\current\\aria2c.exe") to use
Scoop's dynamic prefix resolution instead; instruct users to run `scoop install
aria2-openssl` and set the aria2-path using `$(scoop prefix
aria2-openssl)\\aria2c.exe` so non-default Scoop roots work (refer to the
"notes" key in tutanota.json to locate and update the string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/tutanota.json`:
- Line 20: The PR is missing local manifest validation steps in the tutanota
manifest notes; update the "notes" entry in bucket/tutanota.json (the notes
field shown in the diff) to include the three suggested local testing commands
and brief guidance: run .\bin\checkver.ps1 -App tutanota -f to validate version,
.\bin\formatjson.ps1 -App tutanota to format the manifest, and scoop install
.\bucket\tutanota.json -a 64bit to test installation locally; ensure the notes
string clearly lists these steps so reviewers can reproduce local validation.
- Line 20: Update the "notes" value that currently hardcodes the Scoop root path
("$env:USERPROFILE\\scoop\\apps\\aria2-openssl\\current\\aria2c.exe") to use
Scoop's dynamic prefix resolution instead; instruct users to run `scoop install
aria2-openssl` and set the aria2-path using `$(scoop prefix
aria2-openssl)\\aria2c.exe` so non-default Scoop roots work (refer to the
"notes" key in tutanota.json to locate and update the string).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1939967-0622-47cb-9e01-062ce692e888

📥 Commits

Reviewing files that changed from the base of the PR and between feaebf6 and 4ff5dd6.

📒 Files selected for processing (1)
  • bucket/tutanota.json

@B67687 B67687 force-pushed the tutanota-tls-note branch from 4ff5dd6 to e795354 Compare May 1, 2026 03:48
@B67687 B67687 closed this May 1, 2026
@B67687 B67687 deleted the tutanota-tls-note branch May 1, 2026 03:55
@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 1, 2026

Closing this PR - replaced by #17723 which uses the immediate workaround scoop install -a that works today without waiting for the aria2-openssl package to be merged. This makes the note useful immediately rather than being blocked by another PR.

@z-Fng z-Fng added the duplicate label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants