Fixes #38916 - Update EditorHostSelect to pf5

[adamlazik1]

Use the shared PF5 AutocompleteInput for the template editor preview host
field.

Drop patternfly-react-extensions and its webpack vendor bundle and SCSS
imports now that the editor no longer uses the extensions Select
component.

Co-authored-by: Lukas Jezek ljezek@redhat.com

[kfamilonidis]

Good approach. It would help to cherry-pick these changes to align with the tests already written for this part here.

[MariaAga]

I didnt read the code yet, but isnt

replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead

The same as this pr? #10734

[adamlazik1]

I didnt read the code yet, but isnt

replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead

The same as this pr? #10734

@MariaAga mostly the same but EditorHostSelect has some extra properties and I don't really know whether adjusting AutocompleteInput to replace EditorHostSelect won't break the use of AutocompleteInput in other places.

[pondrejk]

Took a brief look at the changes and also at airgun:

• I see editor-select-container stayed as an ID, which is great but I don't see it referenced in airgun anyway -- that's probably something to be changed, but this fact tells me that the tests doing template preview rely on the first host prefill, so in that matter this will definitely be a breaking change for ds tests. I'd like you to consider getting back to the fist item prefill, I think it was a nice click saver for users
• the padding issue is definitely a problem for me, imho its ok to make the navbar thicker if we cant make the dropdown thinner
• also I'd add some definition to the dropdown border, I imagine it would be hard to read, or maybe if it was with white background, not gray on gray

[adamlazik1]

After discussion with @Lukshio we determined that it is more beneficial to first update EditorHostSelect to PF5, then update the EditorNavBar to PF5 as the parent component.

[pnovotny]

Couple things found during PR testing:

• one scenario where the host search acts a bit strange:

If you have selected a host (given the host has ID 5), you clear the text and type in some string that doesn't match anything, for example ddd.
Message No results found for ddd is shown (this is correct).
Now, if you click somewhere around the search input that makes the message disappear, the search string ddd is replaced with 5 - the host ID.
Screen capture:
host-selector-search-id-instead-of-name.webm

• as already commented here,
  the bottom padding of the host select and vertical alignment of Safemode checkbox is little bit off . But I am also fine with being it fixed in the EditorNavbar PR.

[Lukshio]

@adamlazik1 I think that this PR has gone too far with the changes, so now it should be better to start from the original code.

I wrote some comments, but overall: the complexity of the code has reached unwanted state where lot of things are being rewritten/remapped.

I've created minimal patch that should solve all of the issues with minimal changes. Try to apply the patch, if it will work correctly, as it does in my setup, new testing from @pnovotny will be needed.

0001-minimal-patch_2.patch

[adamlazik1]

Thanks @Lukshio, I applied your patch and confirmed that EditorHostSelect appears to work as intended.

[Lukshio]

Looks good, I also verified webhooks with new autocomplete, looks ok. @pnovotny please check QE side.

@adamlazik1 just fix the failing tests.

[pnovotny]

Reverified with the latest add-ons. QA-wise LGTM 👍

The issues from my last verification are fixed:

• Filtering now works correctly, no problems found.
• Vertical alignment of the host select and Safemode checkbox now look fine too.

[Lukshio]

I also add my ack. It looks kida weird to have lot of "changes" in tree, but that was just rebase. Confirmed that code didn't change since @pnovotny lgtm.

[adamlazik1]

Thanks @pnovotny and @Lukshio. I squashed everything into one commit, no further changes to code were made. This is now ready for merging.

[pnovotny]

Thanks @pnovotny and @Lukshio. I squashed everything into one commit, no further changes to code were made. This is now ready for merging.

ACK

[MariaAga]

Did a quick look at the code and going to trust @Lukshio and @pnovotny acks.
Thanks everyone!

Lukshio commented "I also add my ack."

[MariaAga]

@theforeman/packaging:

Merging is blocked
Waiting on code owner review from theforeman/packaging.

@evgeni
on Nov 21, 2025
Deleting things from package.json will always get you a 📦 ACK from me ;-)