Skip to content

Editor Host Select PF4 Refactor#9719

Closed
LiorKGOW wants to merge 1 commit intotheforeman:developfrom
LiorKGOW:editor-host-select-pf4-refactor
Closed

Editor Host Select PF4 Refactor#9719
LiorKGOW wants to merge 1 commit intotheforeman:developfrom
LiorKGOW:editor-host-select-pf4-refactor

Conversation

@LiorKGOW
Copy link
Copy Markdown
Contributor

@LiorKGOW LiorKGOW commented May 28, 2023

In Progress...

  • Converting the class component into a functional component in order to use React hooks which are used in the Select component in PF4

Status:
Working on adjusting PF4 Select component to our situation
using Custom Filtering Version of Select

@theforeman-bot
Copy link
Copy Markdown
Member

Issues: #36432

@theforeman-bot
Copy link
Copy Markdown
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Copy Markdown
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Copy Markdown
Member

Can one of the admins verify this patch?

@LiorKGOW LiorKGOW force-pushed the editor-host-select-pf4-refactor branch from 092cbe8 to 74d44cb Compare May 29, 2023 16:09
@LiorKGOW LiorKGOW changed the title Editor host select PF4 refactor Editor Host Select PF4 Refactor May 29, 2023
@nadjaheitmann
Copy link
Copy Markdown
Contributor

We are working on the transition to PF5 now, so I guess we can close this one @LiorKGOW ?

@nadjaheitmann
Copy link
Copy Markdown
Contributor

Closing this as we now have a new PR for PF5: #10777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants