-
Notifications
You must be signed in to change notification settings - Fork 112
Make foremanctl customizations visible #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jafiala
wants to merge
17
commits into
theforeman:master
Choose a base branch
from
jafiala:add-additional-config-foremanctl-SAT-43780
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−20
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
043fcdd
Make foremanctl customizations visible
jafiala 7c0d3d7
Remove extra endif
jafiala f12b657
Fix ifdefs
jafiala bcd8465
Correctly wrap ifdefs around cname assembly
jafiala 868219d
Dummy commit
jafiala 684e0d1
Hide customize assembly from disconnected guide
jafiala 5138d85
Apply suggestions from style review
jafiala d4609f5
Revert "Hide customize assembly from disconnected guide"
jafiala 67068d4
Remove customize assembly from disconnected guide
jafiala f7d5a89
Restructure without nested assemblies
jafiala 706eee0
Fix inline conditionals
jafiala 781b475
Remove trailing whitespace
jafiala d3ba7b9
Make http proxy visible
jafiala 46bc4d9
remove unverified foremanctl procs
jafiala abd632b
Omit deploying custom certs to host from foremanctl
jafiala ddaf373
Merge branch 'master' into add-additional-config-foremanctl-SAT-43780
jafiala 7b6a30d
Fix endif syntax
jafiala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this line yet. I checked the built docs expecting that the ribbon is missing for foremanctl-katello, but it's still there as it should be. However, wouldn't it be easier to move line 102 to 95?