Make foremanctl customizations visible#4803
Make foremanctl customizations visible#4803jafiala wants to merge 17 commits intotheforeman:masterfrom
Conversation
github-actions
Bot
added
Needs tech review
| endif::[] | ||
| ifdef::katello,orcharhino,satellite[] | ||
|
|
||
| include::common/assembly_configuring-an-alternate-cname.adoc[leveloffset=+2] | ||
|
|
||
| ifndef::foremanctl[] | ||
|
|
There was a problem hiding this comment.
This extends the ifndef::foremanctl[] to also cover assembly_configuring-an-alternate-cname.adoc because this is included in the foremanctl-specific customize assembly
pr-processor
Bot
added
the
Waiting on contributor
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
|
Avoiding nesting assemblies means reverting the structure, taking it back into draft. DONE |
|
The following chapters might (!) not work for foremanctl:
|
OK. Can we resolve it now? If not, I'll hide them from foremanctl builds for now an get back to them later. |
As we don't have PXE for foremanctl right now, 4.1.8 is something that we couldn't come to a resolution anyway. 4.1.3 would need some testing, which I don't have the time right now, so unless someone wants to jump in, I'd just hide both. |
evgeni
left a comment
evgeni
left a comment
There was a problem hiding this comment.
tech ack, tack ack, here's my tech ack
(to be read with the voice of Tom Jones)
4 participants
What changes are you introducing?
Add additional configurations that don't require changes in foremanctl
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To make foremanctl installations work
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
https://redhat.atlassian.net/browse/SAT-43780
This necessitates also some changes in the ifdef structure, which includes also dropping Appendix A from foremanctl builds (SAT-44660)
Contributor checklists
Please cherry-pick my commits into: