Skip to content

Reset all per-parse state in JSON::ResumableParser#clear #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Jun 18, 2026
+17 −0
Merged

Reset all per-parse state in JSON::ResumableParser#clear #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2487,6 +2487,9 @@ static VALUE cResumableParser_clear(VALUE self)
parser->frames.head = 0;
parser->value_stack.head = 0;
parser->state.name_cache.length = 0;
parser->state.current_nesting = 0;
parser->state.in_array = 1;
parser->state.emitted_deprecations = 0;
Comment on lines +2490 to +2492

@byroot byroot Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just memset(parser, 0, sizeof(*parser)).

@byroot byroot Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not. Because then we need to be careful not to leak the buffers we allocated etc. Nevermind.

parser->state.start = parser->state.cursor = parser->state.end = NULL;
return self;
}
Expand Down
14 changes: 14 additions & 0 deletions test/json/resumable_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,20 @@ def test_parse_with_empty_buffer_keeps_parser_usable
assert_equal [4], @parser.value
end

def test_clear_resets_nesting_depth
# An unfinished document leaks a nesting level; #clear must reset it so a later shallow
# document is not rejected with a spurious NestingError.
parser = new_parser(max_nesting: 10)
10.times do
parser << '[1' # opens an array that is never closed before clear
parser.parse
parser.clear
end
parser << '[1]'
assert parser.parse
assert_equal [1], parser.value
end

def test_parse_document_direct
@parser << '[true]'
assert_equal true, @parser.parse
Expand Down
Loading