Reset all per-parse state in JSON::ResumableParser#clear#1020
Merged
Conversation
byroot
reviewed
Jun 18, 2026
Comment on lines
+2480
to
+2482
| parser->state.current_nesting = 0; | ||
| parser->state.in_array = 1; | ||
| parser->state.emitted_deprecations = 0; |
Member
There was a problem hiding this comment.
I wonder if we should just memset(parser, 0, sizeof(*parser)).
Member
There was a problem hiding this comment.
I guess not. Because then we need to be careful not to leak the buffers we allocated etc. Nevermind.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c40813e to
89ad4c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
#cleardoes not resetcurrent_nesting.This PR resets
current_nesting.It also resets
in_arrayandemitted_deprecationsjust for case, though I am not sure whether we should resetemitted_deprecationsor not.