Skip to content

fix(ci): replace msbuild longbridge.sln with cmake --build for Windows #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hogan-yuan merged 2 commits into from
Jun 10, 2026
+21 −15
Merged

fix(ci): replace msbuild longbridge.sln with cmake --build for Windows #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf7624
fix(ci): replace msbuild longbridge.sln with cmake --build for Windows
hogan-yuan Jun 10, 2026
be9173b
fix(ci): use taiki-e/install-action to install cargo-make
hogan-yuan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ jobs:
uses: lukka/get-cmake@latest

- name: Install cargo make
run: cargo install cargo-make
uses: taiki-e/install-action@v2
with:
tool: cargo-make

- name: Check with clippy
run: cargo clippy -p longbridge-c --all-features
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,9 @@ jobs:
uses: lukka/get-cmake@latest

- name: Install cargo make
run: cargo install cargo-make
uses: taiki-e/install-action@v2
with:
tool: cargo-make

- name: Build
if: ${{ matrix.settings.target != 'aarch64-apple-darwin' }}
Expand Down Expand Up @@ -348,7 +350,9 @@ jobs:
uses: lukka/get-cmake@latest

- name: Install cargo make
run: cargo install cargo-make
uses: taiki-e/install-action@v2
with:
tool: cargo-make

- name: Build
if: ${{ matrix.settings.target != 'aarch64-apple-darwin' }}
Expand Down
12 changes: 6 additions & 6 deletions c/Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ args = ["cargo-build_longbridge_c"]
cwd = "cmake.build"

[tasks.c.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Debug", "/t:cargo-build_longbridge_c"]
command = "cmake"
args = ["--build", ".", "--config", "Debug", "--target", "cargo-build_longbridge_c"]
cwd = "cmake.build"

[tasks.c-release.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Release", "/t:cargo-build_longbridge_c"]
command = "cmake"
args = ["--build", ".", "--config", "Release", "--target", "cargo-build_longbridge_c"]
cwd = "cmake.build"

[tasks.c-test]
Expand All @@ -24,6 +24,6 @@ args = ["test-c"]
cwd = "cmake.build"

[tasks.c-test.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Debug", "/t:test-c"]
command = "cmake"
args = ["--build", ".", "--config", "Debug", "--target", "test-c"]
cwd = "cmake.build"
12 changes: 6 additions & 6 deletions cpp/Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ args = ["longbridge_cpp"]
cwd = "cmake.build"

[tasks.cpp.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Debug", "/t:longbridge_cpp"]
command = "cmake"
args = ["--build", ".", "--config", "Debug", "--target", "longbridge_cpp"]
cwd = "cmake.build"

[tasks.cpp-release.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Release", "/t:longbridge_cpp"]
command = "cmake"
args = ["--build", ".", "--config", "Release", "--target", "longbridge_cpp"]
cwd = "cmake.build"

[tasks.cpp-test]
Expand All @@ -24,6 +24,6 @@ args = ["test-cpp"]
cwd = "cmake.build"

[tasks.cpp-test.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Debug", "/t:test-cpp"]
command = "cmake"
args = ["--build", ".", "--config", "Debug", "--target", "test-cpp"]
cwd = "cmake.build"
Loading