Skip to content

fix(ci): replace msbuild longbridge.sln with cmake --build for Windows#541

Merged
hogan-yuan merged 2 commits into
mainfrom
fix/cmake-windows-vs2026
Jun 10, 2026
Merged

fix(ci): replace msbuild longbridge.sln with cmake --build for Windows#541
hogan-yuan merged 2 commits into
mainfrom
fix/cmake-windows-vs2026

Conversation

@hogan-yuan

Copy link
Copy Markdown
Member

Problem

windows-latest runner was upgraded to VS2026 (MSBuild 18.6.3), which generates a different .sln filename than VS2022. The Makefile.toml had longbridge.sln hardcoded, causing:

MSBUILD : error MSB1009: Project file does not exist.
Switch: longbridge.sln

Fix

Replace msbuild longbridge.sln with cmake --build . in c/Makefile.toml and cpp/Makefile.toml. cmake --build delegates to the underlying build system and doesn't depend on the .sln filename.

Before:

[tasks.c.windows]
command = "msbuild"
args = ["longbridge.sln", "-p:Configuration=Debug", "/t:cargo-build_longbridge_c"]

After:

[tasks.c.windows]
command = "cmake"
args = ["--build", ".", "--config", "Debug", "--target", "cargo-build_longbridge_c"]

This change is backward-compatible with VS2022 and works with any cmake generator.

hogan-yuan and others added 2 commits June 10, 2026 18:57
windows-latest upgraded to VS2026 (MSBuild 18.6.3) which generates
a different .sln filename. Using cmake --build avoids the hardcoded
filename and works with any generator.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cargo install cargo-make fails intermittently due to crates.io network
issues (HTTP2 framing errors). taiki-e/install-action downloads
pre-built binaries from GitHub Releases, which is faster and more reliable.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@hogan-yuan hogan-yuan merged commit 4300207 into main Jun 10, 2026
56 checks passed
@hogan-yuan hogan-yuan deleted the fix/cmake-windows-vs2026 branch June 10, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant