feat(playground)!: redesign sidebar with nav-based layout and theme editing#716
Open
effie-ms wants to merge 48 commits into
Open
feat(playground)!: redesign sidebar with nav-based layout and theme editing#716effie-ms wants to merge 48 commits into
effie-ms wants to merge 48 commits into
Conversation
|
Hey! This is your new endpoint: https://ef3ccbb6.widget-playground-1so.pages.dev |
|
Hey! This is your new endpoint: https://a011f626.widget-playground-1so.pages.dev |
|
Hey! This is your new endpoint: https://3982bdd4.widget-playground-1so.pages.dev |
|
Hey! This is your new endpoint: https://27687382.widget-playground-1so.pages.dev |
…lor-mix for hovers
… utility functions
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB:
To be reviewed after: #745 and #746 (isolated fixes for
@lifi/widget)Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-348/restyle-widget-playground
Why was it implemented this way?
Widget changes
These affect the published
@lifi/widgetpackage.drop-shadow→box-shadowincreateTheme.tsandwatermelonLight.ts— updated to support spread control (to make it configurable from the playground sidebar)grey[200]/grey[700]→grey[300]/grey[800]inSendToWalletPage.style.tsx(other grey pairs are not used within the widget)MuiDraweradded to allowed theme component overrides, now mergeable viacreateTheme.ts- to be able to customize Drawer variantAppLayout- not to cut shadow.Playground changes
DrawerControls+ExpandableCardaccordion → floating sidebar withSidebarViewnav + slide-in detail views@monaco-editor/reactand@mui/labdependencies - not supporting code editor anymorewithFloatingDrawer()wrapper isolates playground drawer overrides from widget themesChecklist before requesting a review