Skip to content

chore(playground): merge main into playground-updates and align with EMB-389 API renames#748

Merged
effie-ms merged 7 commits into
playground-updatesfrom
feature/emb-389-rebase-playground-updates
May 27, 2026
Merged

chore(playground): merge main into playground-updates and align with EMB-389 API renames#748
effie-ms merged 7 commits into
playground-updatesfrom
feature/emb-389-rebase-playground-updates

Conversation

@chybisov
Copy link
Copy Markdown
Member

Which Linear task is linked to this PR?

EMB-389 — follow-up to bring PR #716 up to date with the four merged EMB-389 PRs.

Why was it implemented this way?

PR #716 was written against main before the EMB-389 PRs (#741, #742, #743, #744) and PR #740 (mitt → eventemitter3) merged. The playground source still referenced the renamed/removed APIs, so a straight rebase produces a non-compiling tree.

This PR is a coordination layer: merges current main into playground-updates (single merge commit), resolves the direct conflicts, and sweeps the remaining semantic references to the new API surface so the result compiles, passes tests, and renders the widget correctly.

Merge into playground-updates, not main. Once this lands on playground-updates, PR #716 is ready to re-review against current main.

Direct conflicts resolved

Semantic renames applied (#716 code referencing removed APIs)

  • WidgetSubvariant / SplitSubvariant / SubvariantOptionsWidgetMode / SplitMode / ModeOptions in utils/mode.ts (type fields renamed: subvariantmode).
  • useConfigSubvariant / useConfigSubvariantOptionsuseConfigMode / useConfigModeOptions in store/widgetConfig/useConfigValues.ts.
  • ModeDetailView.tsx — switched to setMode, defaultConfig?.mode, modeOptions?.split.
  • VariantDetailView.tsx — chain sidebar toggle now reads hiddenUI?.chainSidebar (was subvariantOptions?.wide?.disableChainSidebar).
  • hooks/useSidebarNavLabels.ts — same hook + config field renames.

E2E selector update

PR #716's playground sidebar replaces the "Subvariant" UI label with "Mode". The e2e test selector regex /^Subvariant/i would have failed against the new label. Updated:

  • e2e/tests/components/PlaygroundSidebar.ts:17,29subvariantButtonmodeButton, regex /^Subvariant/i/^Mode/i.
  • e2e/tests/playground/smoke.spec.ts:21 — same field name.

#740 (mitt → eventemitter3) impact

Verified — all WidgetEvent.* enum members used in the playground (WidgetEventsDetailView, WidgetEventsControls, etc.) still exist on main. No playground changes needed beyond what the auto-merge already absorbed.

Visual showcase

N/A — coordination PR. Smoke test confirms:

  • Playground loads at http://localhost:3000 with the new floating sidebar
  • "Mode" button (renamed from "Subvariant") opens the ModeDetailView
  • Switching mode (Exchange → Refuel) updates the widget and the sidebar label correctly
  • Only pre-existing TomoWalletAdapter console warnings; no new errors

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.
  • If this PR modifies the Widget API or adds new features that require documentation, I have updated the documentation in the public-docs repository.

Verification

  • pnpm check — 1 pre-existing info (useless React fragment in ThemePaletteSection.tsx, not from this PR)
  • pnpm check:types — all packages pass
  • pnpm check:circular-deps — clean
  • pnpm --filter @lifi/widget test — 35/35
  • pnpm --filter @lifi/widget-playground test — 14/14
  • pnpm build — all packages
  • Dev server smoke test — widget mounts, Mode switching works

@effie-ms effie-ms merged commit eed9481 into playground-updates May 27, 2026
5 checks passed
@effie-ms effie-ms deleted the feature/emb-389-rebase-playground-updates branch May 27, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants