fix: extend SBUS2 and UART inversion guards to include RP2350#11592
Draft
sensei-hacker wants to merge 1 commit into
Draft
fix: extend SBUS2 and UART inversion guards to include RP2350#11592sensei-hacker wants to merge 1 commit into
sensei-hacker wants to merge 1 commit into
Conversation
USE_TELEMETRY_SBUS2 was gated to F7/H7 only; RP2350 also has bi-directional UART inversion. AT32F43x lacks hardware RXINV/TXINV (confirmed via register map) and is excluded. Also removes dead !defined(STM32F7) from serial_uart.c, which is compiled only for F4 via stm32-stdperiph.cmake — STM32F7 could never be defined in that translation unit.
|
Test firmware build ready — commit Download firmware for PR #11592 237 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_TELEMETRY_SBUS2was gated to STM32F7/H7 only. RP2350 also has bi-directional UART inversion capability and is now included.!defined(STM32F7)fromserial_uart.c. That file is compiled only for STM32F4 viastm32-stdperiph.cmake(included exclusively bystm32f4.cmake), soSTM32F7can never be defined in that translation unit. Confirmed by inspecting the MATEKF722 build directory — noserial_uart.c.objpresent.Changes
src/main/target/common.h— add|| defined(RP2350)toUSE_TELEMETRY_SBUS2guard; improve comment to name both excluded platformssrc/main/drivers/serial_uart.c— remove tautological&& !defined(STM32F7)fromusartConfigurePinInversionTesting
Code Review
Reviewed with inav-code-review — no critical or important issues found.
Documentation not needed (preprocessor guard fix, no user-visible behaviour change on existing targets).