Apply optional token_refresh_failed fallback in with_api/4#198
Merged
maennchen merged 1 commit intoJun 16, 2026
Merged
Conversation
When resolve_api_auth/2 fails with token_refresh_failed and optional is true, fall back to executing the request without credentials, mirroring the existing handling in with_repo/3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ericmj
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_repo/3falls back to executing without credentials whenresolve_repo_authreturns{auth_error, token_refresh_failed}andoptionalistrue.with_api/4was missing the equivalent handling, so an optional API call would surface the refresh failure as an error instead of proceeding anonymously.This adds the matching clause to
with_api/4, placed before the catch-all error clause so non-optional calls still propagate the error.Addresses hexpm/hex#1143 (comment).