Skip to content

Update to use hex_auth module#1143

Merged
maennchen merged 2 commits into
hexpm:mainfrom
maennchen:jm/refactor
Jun 16, 2026
Merged

Update to use hex_auth module#1143
maennchen merged 2 commits into
hexpm:mainfrom
maennchen:jm/refactor

Conversation

@maennchen

@maennchen maennchen commented Apr 13, 2026

Copy link
Copy Markdown
Member

Upstream PR: hexpm/hex_core#178

@maennchen maennchen force-pushed the jm/refactor branch 4 times, most recently from 5657ba5 to 54ec1ba Compare April 16, 2026 12:56
@maennchen maennchen marked this pull request as ready for review June 9, 2026 14:36

@ericmj ericmj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we lost support for HEX_OTP environment variable for non-interactive use.

Hex.OnceCache looks like dead code now? Delete it if we no longer use it.

Comment thread lib/hex/api/oauth.ex Outdated
Comment thread lib/hex/auth.ex
Comment thread lib/hex/remote_converger.ex
Comment thread src/mix_hex_cli_auth.erl
Comment thread src/mix_hex_cli_auth.erl
Comment thread lib/hex/update_checker.ex Outdated
Comment thread lib/hex/oauth.ex Outdated
Comment thread lib/hex/repo.ex Outdated
Comment thread src/mix_hex_cli_auth.erl
@maennchen maennchen force-pushed the jm/refactor branch 4 times, most recently from b83dfe1 to a43a473 Compare June 16, 2026 16:46
@maennchen maennchen force-pushed the jm/refactor branch 2 times, most recently from 4ad355c to 658543d Compare June 16, 2026 17:46
@maennchen maennchen requested a review from ericmj June 16, 2026 17:47

@ericmj ericmj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Hex.API.OAuth.device_authorization/2, poll_device_token/1, and refresh_token/1 dead code now?

Comment thread lib/hex/repo.ex Outdated
@maennchen maennchen merged commit cda8717 into hexpm:main Jun 16, 2026
13 checks passed
@maennchen maennchen deleted the jm/refactor branch June 16, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants