Skip to content

Separate diffuse runner used to build containers#273

Open
denis-zaitsev wants to merge 1 commit into
mainfrom
separate-sh-runner-for-diffuse
Open

Separate diffuse runner used to build containers#273
denis-zaitsev wants to merge 1 commit into
mainfrom
separate-sh-runner-for-diffuse

Conversation

@denis-zaitsev

@denis-zaitsev denis-zaitsev commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Docker publish jobs in diff-use/sampleworks were stuck waiting for a runner.

The issue started in commit 9f17fc4 (Run docker workflow on Astera builder), which changed the Docker workflow from ubuntu-latest to astera-sh-builder.

astera-sh-builder existed, but it was registered to the Astera-org GitHub org. The sampleworks repo is under diff-use, so GitHub could not match the job to that runner.

Fix

Add a new diff-use CPU runner scale set named diffuse-sh-builder in the existing arc-runners namespace.

Update the sampleworks Docker workflow to use:

runs-on: diffuse-sh-builder

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Chores**
  * Updated the build workflow to use a shared runner for several container-related jobs.
  * Kept the rest of the automation unchanged, including build steps, tagging, validation, and job dependencies.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff151950-ae83-4a55-827b-caffd3d01e79

📥 Commits

Reviewing files that changed from the base of the PR and between 2777630 and cce0eec.

📒 Files selected for processing (1)
  • .github/workflows/docker.yml

📝 Walkthrough

Walkthrough

Three jobs in .github/workflows/docker.ymlsync_checkpoints, public, and astera—have their runs-on runner changed from astera-sh-builder to diffuse-sh-builder. No other workflow logic is modified.

Changes

Docker Workflow Runner Update

Layer / File(s) Summary
Runner label updates for all three jobs
.github/workflows/docker.yml
sync_checkpoints (line 33), public (line 108), and astera (line 180) jobs switch from astera-sh-builder to diffuse-sh-builder.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • diff-use/sampleworks#251: Directly related — also modifies runner assignments for the same three jobs (sync_checkpoints, public, astera) in .github/workflows/docker.yml.

Suggested reviewers

  • manzuoni-astera
  • marcuscollins

🐇 Three jobs once ran on a different trail,
Now diffuse-sh-builder tips the scale!
A single runner, unified and neat,
Hop hop hop — the workflow's complete! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the change and indicates the Docker build jobs now use a separate diffuse runner.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch separate-sh-runner-for-diffuse

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant