Skip to content

Fix odd chaining#84

Open
bwbohl wants to merge 3 commits intodeutschestextarchiv:masterfrom
baz-ga:fix-oddChaining
Open

Fix odd chaining#84
bwbohl wants to merge 3 commits intodeutschestextarchiv:masterfrom
baz-ga:fix-oddChaining

Conversation

@bwbohl
Copy link
Copy Markdown
Contributor

@bwbohl bwbohl commented Feb 10, 2020

All ODD files do not properly reference their code-source in schemaSpec/@source. This PR introduces a the following values:

  • tei:3.5.0 in basisformat_all.odd
  • dist/basisformat_all.xml in both basisformat.odd and basisformat_ms.odd

Please consider this a hot-fix (for both master and dev branches).

Before this commit the TEI release forming the basis of DTABf was only visible in the XML-comment that has been inserted into generated RNG files by the TEI-Stylesheets. With this commit the TEI v3.5.0 release will be referenced in a stable way that allows for regenration of this explicit DTABf version at a later release state of TEI.
Prior to this commit, both basisformat.odd and  basisformat_ms.odd had a wildcard pointer `/path/to/file/basisformat_all.xml` as `@source`. This commit introduces a repo internal (and thus stable) reference  to the compiled ODD at `dist/basisformat_all.xml`.
@bwbohl bwbohl mentioned this pull request Feb 11, 2020
@bwbohl
Copy link
Copy Markdown
Contributor Author

bwbohl commented Apr 22, 2022

any chance this get's implemented?

@bwbohl
Copy link
Copy Markdown
Contributor Author

bwbohl commented Jun 8, 2022

just another gentle bump to provoke a reaction ;-)

@rettinghaus
Copy link
Copy Markdown

Has this been addressed otherwise? If yes, then this PR maybe should be closed after four years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants