Fix odd chaining dev#85
Open
bwbohl wants to merge 2 commits intodeutschestextarchiv:devfrom
Open
Conversation
Prior to this commit, both basisformat.odd and basisformat_ms.odd had a wildcard pointer `/path/to/file/basisformat_all.xml` as `@source`. This commit introduces a repo internal (and thus stable) reference to the compiled ODD at `dist/basisformat_all.xml`.
Before this commit the TEI release forming the basis of DTABf was only visible in the XML-comment that has been inserted into generated RNG files by the TEI-Stylesheets. With this commit the TEI v3.5.0 release will be referenced in a stable way that allows for regenration of this explicit DTABf version at a later release state of TEI.
Contributor
Author
|
any chance this get added soone? |
Contributor
Author
|
just another gentle bump to provoke a reaction ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All ODD files do not properly reference their code-source in
schemaSpec/@source. This PR introduces a the following values:tei:3.5.0inbasisformat_all.odddist/basisformat_all.xmlin bothbasisformat.oddandbasisformat_ms.oddPlease consider this a hot-fix (for both master and dev branches).
While this PR makes the fix on the dev branch #84 provides the same fix for the master branch