feat(google-docs): add cell-level mapping review to document outline [INTEG-3572]#10861
feat(google-docs): add cell-level mapping review to document outline [INTEG-3572]#10861Harika Kondur (harikakondur) wants to merge 16 commits intogoogle-docs-document-outlinefrom
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
…ful/apps into feat/cell-level-mappings
…Outline for mapping review
375803f to
806b561
Compare
d1463f7 to
ac5b4bc
Compare
There was a problem hiding this comment.
Nice update! 🙌 Paired the PR review with JuliRossi and left some comments!
The was reviewed to the best of our abilities given the length of the PR.
The most important part for us, is that there are some places in which the fieldType and fieldName are being fetch incorrectly, also check entry name.
| const [isConfirmCancelModalOpen, setIsConfirmCancelModalOpen] = useState(false); | ||
|
|
||
| const isMappingReview = isMappingReviewSuspendPayload(payload); | ||
| const documentTitle = payload.documentTitle || 'Selected document'; |
There was a problem hiding this comment.
The document title comes from the normalized document that's in the payload.
apps/google-docs/src/locations/Page/components/mainpage/MappingReviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/google-docs/src/locations/Page/components/mainpage/ModalOrchestrator.tsx
Outdated
Show resolved
Hide resolved
| type SortableItem = | ||
| | { kind: 'block'; position: number; block: NormalizedDocumentContentBlock } | ||
| | { kind: 'table'; position: number; table: NormalizedDocumentTable } | ||
| | { kind: 'tab'; position: number; tab: NormalizedDocumentTabBlock }; |
There was a problem hiding this comment.
We could use the existent types from above here. Also, we could extract this type outside the method
| if (!currentTab) { | ||
| currentTab = { id: normalizedDocument.documentId, name: '', segments: [] }; | ||
| tabs.push(currentTab); | ||
| } |
There was a problem hiding this comment.
Why do we need this?
| }; | ||
|
|
||
| measureOffsets(); | ||
| window.addEventListener('resize', measureOffsets); |
There was a problem hiding this comment.
Why do we need a resize and an event here?
apps/google-docs/src/locations/Page/components/review/DocumentOutline.tsx
Outdated
Show resolved
Hide resolved
| blockId: string; | ||
| }; | ||
|
|
||
| export type TableImageSourceRef = ImageSourceRefBase & { |
There was a problem hiding this comment.
We could create a type for this and reuse it in line 22
There was a problem hiding this comment.
Check if we are duplicating types that already exist
…g and unused utility function
…wFromPreviewCancel handlers
2d94c4a to
a94d855
Compare

Summary
Adds a better Google Docs review screen so we can see mappings at the cell level and make it easier to understand what content maps to which field.
Changes
Files Changed
apps/google-docs/src/locations/Page/components/review/DocumentOutline.tsxapps/google-docs/src/locations/Page/components/review/MappingCard.tsxapps/google-docs/src/locations/Page/components/review/mappingCardPositioning.tsapps/google-docs/src/locations/Page/components/review/buildDocument.tsapps/google-docs/src/locations/Page/Page.tsxapps/google-docs/src/locations/Page/components/mainpage/MainPageView.tsxapps/google-docs/src/locations/Page/components/mainpage/MappingReviewPage.tsxapps/google-docs/src/locations/Page/components/mainpage/ModalOrchestrator.tsxapps/google-docs/src/locations/Page/components/mainpage/PreviewPageView.tsxapps/google-docs/src/types/entryBlockGraph.tsapps/google-docs/src/types/normalizedDocument.tsapps/google-docs/src/types/workflow.tsapps/google-docs/src/types/index.tsapps/google-docs/src/fixtures/googleDocsReview/*apps/google-docs/test/locations/Page/Page.spec.tsxapps/google-docs/test/locations/Page/components/mainpage/ModalOrchestrator.spec.tsxapps/google-docs/test/locations/Page/components/mainpage/PreviewPageView.spec.tsxapps/google-docs/test/locations/Page/components/review/DocumentOutline.spec.tsxapps/google-docs/test/locations/Page/components/review/mappingCardPositioning.spec.tsapps/google-docs/package.jsonapps/google-docs/package-lock.jsonapps/google-docs/tsconfig.jsonScreenshots
Tab Name is visible (Draft)

Partial highlight within cell highlight

Multiple partial highlights from a single cell

Hover interaction
Screen.Recording.2026-04-13.at.12.07.39.AM.mov
Temporary Overview Section with mapping info. (click entry card -> relevant highlights appear)
Uploading Screen Recording 2026-04-13 at 12.09.09 AM.mov…