refactor(google-docs): remove unused resumeMappingReview and resetFlowFromPreviewCancel handlers

Author: harikakondur

apps/google-docs/src/locations/Page/Page.tsx

@@ -72,14 +72,6 @@ const Page = () => {
     setMappingReviewPayload(null);
   };
 
-  const handleResumeMappingReview = async () => {
-    if (!mappingReviewPayload) {
-      return;
-    }
-
-    await modalOrchestratorRef.current?.resumeMappingReview(mappingReviewPayload);
-  };
-
   const activePreviewPayload = mappingReviewPayload;
 
   return (
@@ -90,7 +82,6 @@ const Page = () => {
             payload={activePreviewPayload}
             oauthToken={oauthToken}
             onLeaveReview={handleReturnToMainPage}
-            onResumeMappingReview={handleResumeMappingReview}
           />
         ) : (
           <>

apps/google-docs/src/locations/Page/components/mainpage/MappingReviewPage.tsx

@@ -9,7 +9,6 @@ interface MappingReviewPageProps {
   payload: MappingReviewSuspendPayload;
   oauthToken: string;
   onLeaveReview: () => void;
-  onResumeMappingReview?: () => Promise<void>;
 }
 
 export const MappingReviewPage = ({

apps/google-docs/src/locations/Page/components/mainpage/ModalOrchestrator.tsx

@@ -24,9 +24,6 @@ import { useWorkflowAgent } from '@hooks/useWorkflowAgent';
 
 export interface ModalOrchestratorHandle {
   startFlow: () => void;
-  /** Clears in-progress flow state and returns the page to the main state. */
-  resetFlowFromPreviewCancel: () => void;
-  resumeMappingReview: (payload: MappingReviewSuspendPayload) => Promise<void>;
 }
 
 enum FlowStep {
@@ -68,24 +65,6 @@ export const ModalOrchestrator = forwardRef<ModalOrchestratorHandle, ModalOrches
 
     useImperativeHandle(ref, () => ({
       startFlow: () => setIsUploadModalOpen(true),
-      resetFlowFromPreviewCancel: () => {
-        resetProgress();
-        onResetToMain();
-      },
-
-      resumeMappingReview: async (payload: MappingReviewSuspendPayload) => {
-        if (!activeRunId) {
-          throw new Error('Workflow run id is missing for resume.');
-        }
-
-        // TODO : modify the normalized document and entry block graph with the edited values
-        const workflowRun = await resumeWorkflow(activeRunId, {
-          editedNormalizedDocument: payload.normalizedDocument,
-          entryBlockGraph: payload.entryBlockGraph,
-        });
-
-        handleWorkflowResult(workflowRun);
-      },
     }));
 
     const resetDocumentScopeReview = () => {

apps/google-docs/test/locations/Page/Page.spec.tsx

@@ -61,12 +61,9 @@ vi.mock('../../../src/locations/Page/components/review/DocumentOutline', () => (
   DocumentOutline: () => <div>Mock fixture review</div>,
 }));
 
-const { mockModalOrchestrator, mockResetFlowFromPreviewCancel, mockResumeMappingReview } =
-  vi.hoisted(() => ({
-    mockModalOrchestrator: vi.fn(),
-    mockResetFlowFromPreviewCancel: vi.fn(),
-    mockResumeMappingReview: vi.fn(),
-  }));
+const { mockModalOrchestrator } = vi.hoisted(() => ({
+  mockModalOrchestrator: vi.fn(),
+}));
 
 vi.mock('../../../src/locations/Page/components/mainpage/ModalOrchestrator', () => ({
   ModalOrchestrator: require('react').forwardRef(
@@ -79,19 +76,10 @@ vi.mock('../../../src/locations/Page/components/mainpage/ModalOrchestrator', ()
       },
       ref: React.ForwardedRef<{
         startFlow: () => void;
-        resetFlowFromPreviewCancel: () => void;
-        resumeMappingReview: () => Promise<void>;
       }>
     ) => {
       const handle = {
         startFlow: vi.fn(),
-        resetFlowFromPreviewCancel: () => {
-          mockResetFlowFromPreviewCancel();
-          props.onResetToMain();
-        },
-        resumeMappingReview: async () => {
-          mockResumeMappingReview();
-        },
       };
       if (typeof ref === 'function') {
         ref(handle);
@@ -124,10 +112,7 @@ describe('Page component', () => {
     cleanup();
   });
 
-  beforeEach(() => {
-    mockResetFlowFromPreviewCancel.mockClear();
-    mockResumeMappingReview.mockClear();
-  });
+  beforeEach(() => {});
 
   it('renders MainPageView by default', async () => {
     render(<Page />);

apps/google-docs/test/locations/Page/components/mainpage/ModalOrchestrator.spec.tsx

@@ -197,29 +197,6 @@ describe('ModalOrchestrator', () => {
     });
   });
 
-  it('calls onResetToMain and clears flow state when resetFlowFromPreviewCancel is invoked', async () => {
-    const ref = createRef<ModalOrchestratorHandle>();
-    render(<ModalOrchestrator ref={ref} {...defaultProps} />);
-
-    await act(async () => {
-      ref.current?.startFlow();
-    });
-    fireEvent.click(screen.getByRole('button', { name: 'Pick document' }));
-
-    await waitFor(() => {
-      expect(screen.getByRole('heading', { name: 'Select content type(s)' })).toBeTruthy();
-    });
-
-    await act(async () => {
-      ref.current?.resetFlowFromPreviewCancel();
-    });
-
-    await waitFor(() => {
-      expect(defaultProps.onResetToMain).toHaveBeenCalledTimes(1);
-      expect(screen.queryByRole('heading', { name: 'Select content type(s)' })).toBeNull();
-    });
-  });
-
   it('resets flow when confirming discard in ConfirmCancelModal', async () => {
     const ref = createRef<ModalOrchestratorHandle>();
     render(<ModalOrchestrator ref={ref} {...defaultProps} />);

apps/google-docs/test/locations/Page/components/mainpage/PreviewPageView.spec.tsx

@@ -38,7 +38,6 @@ describe('PreviewPageView', () => {
           payload={mappingReviewPayload}
           oauthToken="oauth-token"
           onLeaveReview={vi.fn()}
-          onResumeMappingReview={vi.fn()}
         />
       </Layout>
     );