Skip to content

Fix ctx.method() usage in README #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanvanburen merged 2 commits into from
Apr 13, 2026
Merged

Fix ctx.method() usage in README #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6503a6
Fix ctx.method() usage in README
stefanvanburen Apr 10, 2026
88ee69f
Merge branch 'main' into svanburen/ctx-method
anuraaga Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,13 @@ class LoggingInterceptor:
"""Implements the MetadataInterceptor protocol."""

async def on_start(self, ctx: RequestContext) -> None:
print(f"Handling {ctx.method.name} request")
print(f"Handling {ctx.method().name} request")

async def on_end(self, token: None, ctx: RequestContext, error: Exception | None) -> None:
if error:
print(f"Failed {ctx.method.name}: {error}")
print(f"Failed {ctx.method().name}: {error}")
else:
print(f"Completed {ctx.method.name} request")
print(f"Completed {ctx.method().name} request")

# Add to your application
app = HelloServiceASGIApplication(
Expand Down
Loading