DNM : Upgrade k8s libraries to v0.36.0 and Go 1.26#1823
Open
sameerforge wants to merge 1 commit intocarvel-dev:developfrom
Open
DNM : Upgrade k8s libraries to v0.36.0 and Go 1.26#1823sameerforge wants to merge 1 commit intocarvel-dev:developfrom
sameerforge wants to merge 1 commit intocarvel-dev:developfrom
Conversation
Signed-off-by: Sameer <sameer.khan@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns kapp-controller with the latest upstream Kubernetes v0.36.0 library stack and migrates the project to the Go 1.26 runtime.
Changes & Technical Impacts
Runtime Requirement: Upstream k8s.io libraries now strictly require Go 1.26.
API Server Lifecycle: The k8s.io/apiserver framework has removed legacy StopCh signals in PostStartHookContext. The initialization logic in pkg/apiserver requires a refactor to a Context-based lifecycle.
Controller-Runtime Interfaces: The upgrade to v0.23.3 introduces signature changes in TypedEventHandler and ResourceEventHandlerRegistration (specifically the new HasSyncedChecker method), affecting reconciler stability.
Dependency Alignment: Includes updates for kube-aggregator, controller-tools, and code-generator to maintain ecosystem synchronization.
❌ Current Build Failures
The following errors were captured after the dependency bump, highlighting the specific areas requiring refactoring:
Click to expand build_errors.log
Analysis of Failures:
Cache Layer: The mismatch in ResourceEventHandlerRegistration shows that controller-runtime and client-go versions in this stack have incompatible internal interfaces.
Reconcilers: The TypedEventHandler errors confirm that our reconciler signatures need to be updated to support new generic arguments.
API Server: The StopCh error is the most critical, indicating that the apiserver library has removed the legacy channel-based shutdown in favor of context.Context.