Fix bugs in esp32 mkimage.erl script#2093
Open
UncleGrumpy wants to merge 2 commits intoatomvm:release-0.7from
Open
Fix bugs in esp32 mkimage.erl script#2093UncleGrumpy wants to merge 2 commits intoatomvm:release-0.7from
UncleGrumpy wants to merge 2 commits intoatomvm:release-0.7from
Conversation
UncleGrumpy
force-pushed
the
mkimage-fix
branch
2 times, most recently
from
dc96177 to
ff8e506
Compare
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
ff8e506 to
91a7825
Compare
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
91a7825 to
83c100e
Compare
This was referenced Feb 10, 2026
UncleGrumpy
force-pushed
the
mkimage-fix
branch
2 times, most recently
from
729ef65 to
89313e8
Compare
petermm
reviewed
Feb 10, 2026
petermm
reviewed
Feb 10, 2026
UncleGrumpy
force-pushed
the
mkimage-fix
branch
4 times, most recently
from
9faef56 to
6913849
Compare
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
6913849 to
0b8b682
Compare
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
0b8b682 to
11704f3
Compare
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
11704f3 to
fe4bd40
Compare
petermm
approved these changes
Apr 10, 2026
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
fe4bd40 to
46a96f0
Compare
pguyot
reviewed
Apr 11, 2026
CHANGELOG.md
Outdated
| - Stop using deprecated `term_from_int32` on ESP32 platform | ||
| - Fixed bug in ESP32 mkimage.sh leading to non-fatal "unary operator expected" error | ||
| - Fixed `fd` leak in ESP32 mkimage.erl | ||
| - Fixed mmkimage.erl unaligned end of data problems that can prevent |
Fix the non-fatal `./build/mkimage.sh: line 38: [: =: unary operator expected` error that can occur when no options are passed. Signed-off-by: Winford <winford@object.stream>
* Fix an FD leak, by properly closing the image file after writing. * Fix a misleading error message when a binary overflows its partition. * Fix an unaligned end of data problem that can prevent flashing with a web-flasher tool. * Catch errors in file:write/2 operations, rather than blindly continue when an error is returned. Closes atomvm#2084 Closes atomvm#2094 Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
mkimage-fix
branch
from
46a96f0 to
d29be8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an FD leak, the image file was never closed properly after writing. Fixes a misleading error message when a binary overflows its partition. Catches errors in file:write/2 operations, rather than blindly continuing.
Closes #2084
Closes #2094
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later