Fix bugs in esp32 mkimage.erl script

Fixes an FD leak, the image file was never closed properly after writing.
Fixes a misleading error message when a binary overlows its partiton.

Closes #2084

Signed-off-by: Winford <winford@object.stream>

Author: UncleGrumpy

src/platforms/esp32/tools/mkimage.erl

@@ -135,62 +135,68 @@ mkimage(RootDir, BootFile, OutputFile, Segments) ->
     io:format("=============================================~n"),
     case file:open(OutputFile, [write, binary]) of
         {ok, Fout} ->
-            lists:foldl(
-                fun(Segment, PrevOffset) ->
-                    SegmentOffset = from_hex(maps:get(offset, Segment)),
-                    case PrevOffset of
-                        undefined ->
-                            no_padding;
-                        _ ->
-                            case SegmentOffset > PrevOffset of
-                                true ->
-                                    Padding = [
-                                        16#FF
-                                     || _ <- lists:seq(1, SegmentOffset - PrevOffset)
-                                    ],
-                                    io:format("Padding ~p bytes~n", [SegmentOffset - PrevOffset]),
-                                    file:write(Fout, Padding);
-                                false ->
-                                    throw(
-                                        io_lib:format(
-                                            "Error: insufficient space for segment ~p.  Over by: ~p bytes~n",
-                                            [
-                                                maps:get(name, Segment), PrevOffset - SegmentOffset
-                                            ]
-                                        )
-                                    )
-                            end
-                    end,
-                    SegmentPaths = [
-                        replace(
-                            "BOOT_FILE", BootFile, replace("ROOT_DIR", RootDir, SegmentPath)
-                        )
-                     || SegmentPath <- maps:get(path, Segment)
-                    ],
-                    case try_read(SegmentPaths) of
-                        {ok, Data} ->
-                            file:write(Fout, Data),
-                            io:format("Wrote ~s (~p bytes) at offset ~s (~p)~n", [
-                                maps:get(name, Segment),
-                                byte_size(Data),
-                                maps:get(offset, Segment),
-                                SegmentOffset
-                            ]),
-                            SegmentOffset + byte_size(Data);
-                        {error, Reason} ->
-                            Fmt =
-                                "Failed to read file ~p  Reason: ~p."
-                                "  Note that a full build is required before running this command.",
-                            throw(io_lib:format(Fmt, [SegmentPaths, Reason]))
-                    end
-                end,
-                undefined,
-                Segments
-            );
+            write_segments(RootDir, BootFile, Fout, Segments);
         {error, Reason} ->
             throw(io_lib:format("Failed to open ~s for writing.  Reason: ~p", [OutputFile, Reason]))
     end.
 
+%% @private
+write_segments(RootDir, BootFile, Fout, []) ->
+    file:close(Fout);
+write_segments(RootDir, BootFile, Fout, [Segment | Segments]) ->
+    SegmentOffset = from_hex(maps:get(offset, Segment)),
+    SegmentPaths = [
+        replace(
+            "BOOT_FILE", BootFile, replace("ROOT_DIR", RootDir, SegmentPath)
+        )
+     || SegmentPath <- maps:get(path, Segment)
+    ],
+    SegmentEnd = case try_read(SegmentPaths) of
+        {ok, Data} ->
+            file:write(Fout, Data),
+            io:format("Wrote ~s (~p bytes) at offset ~s (~p)~n", [
+                maps:get(name, Segment),
+                byte_size(Data),
+                maps:get(offset, Segment),
+                SegmentOffset
+            ]),
+            SegmentOffset + byte_size(Data);
+        {error, Reason} ->
+            Fmt =
+                "Failed to read file ~p  Reason: ~p."
+                "  Note that a full build is required before running this command.",
+            throw(io_lib:format(Fmt, [SegmentPaths, Reason]))
+    end,
+    if Segments == [] -> ok;
+        true ->
+            [PeekNext | _] = Segments,
+            NextOffset = from_hex(maps:get(offset, PeekNext)),
+            case SegmentEnd > NextOffset of
+                true ->
+                    throw(
+                        io_lib:format(
+                            "Error: insufficient space for segment ~p.  Overflows partition by: ~p bytes~n",
+                            [maps:get(name, Segment), SegmentEnd - NextOffset]
+                        )
+                    );
+                false ->
+                    PadSize = NextOffset - SegmentEnd,
+                    case PadSize of
+                        0 ->
+                            ok;
+                        PadSize ->
+                            Padding = [
+                                16#FF
+                             || _ <- lists:seq(1, PadSize)
+                            ],
+                            io:format("Padding ~p bytes~n", [PadSize]),
+                            file:write(Fout, Padding),
+                            ok
+                    end
+            end
+    end,
+    write_segments(RootDir, BootFile, Fout, Segments).
+
 %% @private
 try_read([]) ->
     {error, not_found};