DEVOPS-1123: option to Python package under a dev version tag#191
DEVOPS-1123: option to Python package under a dev version tag#191sebhmg wants to merge 8 commits into
Conversation
github-actions
Bot
changed the title
|
used successfully here: https://github.com/MiraGeoscience/gempy/actions/runs/27281381852 |
There was a problem hiding this comment.
Pull request overview
Adds an explicit switch to allow publishing Python packages built from “dev” version tags, while also aligning these reusable workflows/actions to a specific pre-release CI-tools ref and simplifying the build workflows’ interface.
Changes:
- Introduces a
publish-dev-tagboolean input to the reusable PyPI and rattler publishing workflows, allowing publish even when the version is considered “not publishable”. - Updates several
uses:references to point atv3.7.0-alpha.1. - Removes
version-taghandling/version-output plumbing from the poetry/setuptools build reusable workflows (but one remaining output reference needs cleanup).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/reusable-python-pytest.yml | Pins Python env setup actions to v3.7.0-alpha.1. |
| .github/workflows/reusable-python-publish_rattler_package.yml | Adds publish-dev-tag gate and pins internal workflow/action refs. |
| .github/workflows/reusable-python-publish_pypi_package.yml | Adds publish-dev-tag gate, adjusts Artifactory path version usage, and pins internal workflow/action refs. |
| .github/workflows/reusable-python-build_setuptools_package.yml | Removes version-tag-based version extraction, but leaves a now-stale declared workflow output (blocking). |
| .github/workflows/reusable-python-build_poetry_package.yml | Removes version-tag-based version extraction/output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| outputs: | ||
| build-dir-path: ${{ steps.define-build-path.outputs.dir-path }} | ||
| version: ${{ steps.get-version.outputs.version }} | ||
| steps: |
There was a problem hiding this comment.
L35-37:
Remove just like you did in the poetry_package file. This should resolve the co-pilot comment.
version:
description: Version of the package
value: ${{ jobs.build_package.outputs.version }}
| with: | ||
| build-dir-path: ${{ env.build-dir-path }} | ||
| artifactory-dir-path: ${{ matrix.virtual-repo-name }}/${{ inputs.package-name }}/${{ env.version }} | ||
| artifactory-dir-path: ${{ matrix.virtual-repo-name }}/${{ inputs.package-name }}/${{ env.VERSION_TAG }} |
There was a problem hiding this comment.
Just a heads up:
Previously ${{ env.version }} was coming from setuptools_packages or poetry_package with the Get version step which would remove the v from the tag v1.2.3 --> turning it into 1.2.3.
With this change ${{ env.VERSION_TAG }} is getting it directly from the ${{ inputs.version-tag || github.ref_name }} which might keep the v in the tag name.
If there is no impact on the logic no issue for.
| env: | ||
| INPUTS_VERSION_TAG: ${{ inputs.version-tag }} | ||
| run: | | ||
| if [ "${INPUTS_VERSION_TAG}" = "v0.0.0" ]; then |
There was a problem hiding this comment.
Another heads up:
The old get-version step also failed the build if version-tag == v0.0.0. This is gone now. Was this worth having as guard ?
| id: get-version | ||
| env: | ||
| INPUTS_VERSION_TAG: ${{ inputs.version-tag }} | ||
| run: | |
There was a problem hiding this comment.
Another heads up:
The old get-version step also failed the build if version-tag == v0.0.0. This is gone now. Was this worth having as guard ?
RomFloreani
left a comment
RomFloreani
left a comment
There was a problem hiding this comment.
Added 3 comments:
1 code fix.
2 clarifications (if you think it's not issue feel free to ignore)
DEVOPS-1123 - option to Python package under a dev version tag