DEVOPS-1120: CI-tools: use uv instead of plain pip for setuptools package#190
Closed
sebhmg wants to merge 8 commits into
Closed
DEVOPS-1120: CI-tools: use uv instead of plain pip for setuptools package#190sebhmg wants to merge 8 commits into
sebhmg wants to merge 8 commits into
Conversation
dev version tags are not published by default
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI-tools reusable GitHub workflows to (1) use uv for setuptools-based package builds and (2) expand the publish workflows with an opt-in path to publish “dev” (non-publishable) versions, while also updating several internal action/workflow references to newer tags.
Changes:
- Switched the setuptools build workflow from
pip installtouv pip install(and addedastral-sh/setup-uv). - Added a
publish-dev-taginput to PyPI and rattler publish workflows and relaxed publish gating when explicitly enabled. - Updated several
uses: MiraGeoscience/CI-tools/...references to@v3or@v3.6.0-alpha.1.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/reusable-python-static_analysis.yml | Updates CI-tools action references for environment setup to @v3. |
| .github/workflows/reusable-python-pytest.yml | Updates CI-tools action references for conda/poetry env setup to @v3.6.0-alpha.1 (others to @v3). |
| .github/workflows/reusable-python-publish_rattler_package.yml | Adds publish-dev-tag and updates publish gating / referenced CI-tools action/workflow tags. |
| .github/workflows/reusable-python-publish_pypi_package.yml | Adds publish-dev-tag, adjusts publish condition, and updates referenced CI-tools action/workflow tags. |
| .github/workflows/reusable-python-build_setuptools_package.yml | Introduces uv for installs and removes version-tag-based version extraction. |
| .github/workflows/reusable-python-build_poetry_package.yml | Removes version-tag-based version extraction/output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Publish package | ||
| needs: [build_rattler_package, is_publishable] | ||
| if: ${{ github.repository_owner == 'MiraGeoscience' && needs.is_publishable.outputs.is-publishable == 'true' }} | ||
| if: ${{ github.repository_owner == 'MiraGeoscience' && (needs.is_publishable.outputs.is-publishable == 'true' || inputs.publish-dev-tag) }} |
Comment on lines
+47
to
+51
| publish-dev-tag: | ||
| description: Whether to publish a "dev" version of the package. By default a "dev" version tag is built but not published. | ||
| required: false | ||
| type: boolean | ||
| default: false |
Contributor
Author
There was a problem hiding this comment.
right, I will recreate the PR, with a better scope. Initial issue is cancelled
Contributor
Author
|
not doing the change to uv. Other changes here moved to: #191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1120 - CI-tools: use uv instead of plain pip for setuptools package
changing scope: also introduce an option to publish dev version tags that would normally be built but not published