Conversation
| trigger_type: Literal["REST", "SCHEDULE", "WEBHOOK", "PLATFORM_EVENT"] | ||
| trigger_id: UUID | None = None | ||
| scheduled_at: datetime | None = None | ||
| metadata: dict[str, Any] | None = None |
There was a problem hiding this comment.
Does it also seem logical to you that the scheduled_at field could also be part of this more generic metadata ? Or is it just me ?
b5dc2e3 to
edc621a
Compare
edc621a to
955cf54
Compare
| return request_manager().current_request | ||
|
|
||
|
|
||
| async def register_event_handlers() -> None: |
There was a problem hiding this comment.
This should be register_platform_event_handler instead. It should create the platform event handler instance based on the source path in the server config and (maybe) register it with the dispatcher. Even better if the class registers itself with the dispatcher singleton when created.
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| # or implied. See the License for the specific language governing | ||
| # permissions and limitations under the License. | ||
| """Utility functions to manage platform event triggers.""" |
There was a problem hiding this comment.
Loving this !!!! This is the kind of UX that makes my heart melt.
92e6a51 to
0c67922
Compare
|
@claude /full-review |
|
Claude finished @stefannica's task in 0s —— View job I'll analyze this and get back to you. |
|
@claude /full-review |
1 similar comment
|
@claude /full-review |
|
Claude finished @stefannica's task in 0s —— View job I'll analyze this and get back to you. |
590c67d to
aab06c4
Compare
Documentation Link Check Results❌ Absolute links check failed |
2654726 to
40fd95c
Compare
146a9fd to
069d648
Compare
🔍 Broken Links ReportSummary
Details
📂 Full file paths
|
69f2534 to
009c1a7
Compare
49a42ac to
8d7e63d
Compare
8d7e63d to
028e584
Compare
| default=None, | ||
| title="Extra information for trigger execution like upstream_run_id etc.", | ||
| ) | ||
| pipeline_id: UUID | None = Field( |
There was a problem hiding this comment.
Why is this needed? There is resources.pipeline.id, which should always be included if the metadata is included?
Describe changes
This feature introduces the concept of platform event triggers.
Platform event triggers are a type of triggers that users can set to "trigger" downstream execution based on a ZenML event (for instance a pipeline run completes).
This PR introduces the full backend management of this new trigger type functionality (CLI, SDK, etc.)
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes