Skip to content

Import ViewPagerAndroid from @react-native-community/viewpager...#177

Open
jaywayawyaj wants to merge 2 commits intozbtang:masterfrom
jaywayawyaj:updateForNewRN
Open

Import ViewPagerAndroid from @react-native-community/viewpager...#177
jaywayawyaj wants to merge 2 commits intozbtang:masterfrom
jaywayawyaj:updateForNewRN

Conversation

@jaywayawyaj
Copy link
Copy Markdown

@jaywayawyaj jaywayawyaj commented Sep 26, 2019

...for new React Native upgrade

Comment thread viewpager/ViewPager.js
StyleSheet,
View
} from "react-native";
import ViewPagerAndroid from "react-native-viewpager";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that supposed to be
import ViewPagerAndroid from "@react-native-community/viewpager";
?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Updated, thanks (although have a feeling the PR is somewhat optimistic given the last commit to master)

@kamleshh-bms
Copy link
Copy Markdown

kamleshh-bms commented Oct 2, 2019

Any news? It's time to merge with master branch as it is stopped working with RN 0.61.

@jaywayawyaj
Copy link
Copy Markdown
Author

@kamleshh-bms I reckon this repo isn't gonna merge - last commit was early 2018. Either fork the repo and update yourself or you can use this one which has upgraded already: https://github.com/buildcom/React-Native-ViewPager/tree/2.0.0

@tlow92
Copy link
Copy Markdown

tlow92 commented Oct 2, 2019

Today, react-native newsletter featured https://github.com/CrowdLinker/react-native-pager. Maybe its worth a shot.

@kamleshh-bms
Copy link
Copy Markdown

@kamleshh-bms I reckon this repo isn't gonna merge - last commit was early 2018. Either fork the repo and update yourself or you can use this one which has upgraded already: https://github.com/buildcom/React-Native-ViewPager/tree/2.0.0

It worked. Thank you!

@jaywayawyaj jaywayawyaj changed the title Import ViewPagerAndroid from react-native-community/react-native-view… Import ViewPagerAndroid from react-native-community/viewpager... Oct 6, 2019
@jaywayawyaj jaywayawyaj changed the title Import ViewPagerAndroid from react-native-community/viewpager... Import ViewPagerAndroid from @eact-native-community/viewpager... Oct 6, 2019
@jaywayawyaj jaywayawyaj changed the title Import ViewPagerAndroid from @eact-native-community/viewpager... Import ViewPagerAndroid from @react-native-community/viewpager... Oct 6, 2019
@tncbbthositg
Copy link
Copy Markdown

@zbtang, is this repo still maintained or should we abandon it? Thanks!!

@jaywayawyaj
Copy link
Copy Markdown
Author

@tncbbthositg #177 (comment)

Think this is the best advice, pretty sure @zbtang has left the building!

@johhansantana
Copy link
Copy Markdown

sad, it only takes a minute or two to verify this pull request to work :( will use your suggestion @jaywayawyaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants