Add page scroll and page selected events to IndicatorViewPagerProps#174
Open
martin-braun wants to merge 1 commit intozbtang:masterfrom
martin-braun:patch-1
Open
Add page scroll and page selected events to IndicatorViewPagerProps#174martin-braun wants to merge 1 commit intozbtang:masterfrom martin-braun:patch-1
martin-braun wants to merge 1 commit intozbtang:masterfrom
martin-braun:patch-1
Conversation
This is so the IndicatorViewPager can use those events, too. Both events are properly passed from the ViewPager to the IndicatorViewPager, already. This can be seen here: - https://github.com/zbtang/React-Native-ViewPager/blob/master/viewpager/IndicatorViewPager.js#L66 - https://github.com/zbtang/React-Native-ViewPager/blob/master/viewpager/IndicatorViewPager.js#L81 - https://github.com/zbtang/React-Native-ViewPager/blob/master/viewpager/IndicatorViewPager.js#L87 This fixes #173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so the IndicatorViewPager can use those events, too. Both events are properly passed from the ViewPager to the IndicatorViewPager, already. This can be seen here:
This fixes #173