Skip to content

Implement @react-native-community/viewpager#166

Open
mgonzalezs wants to merge 3 commits intozbtang:masterfrom
mgonzalezs:master
Open

Implement @react-native-community/viewpager#166
mgonzalezs wants to merge 3 commits intozbtang:masterfrom
mgonzalezs:master

Conversation

@mgonzalezs
Copy link
Copy Markdown

No description provided.

Mauricio Gonzalez Salcedo and others added 3 commits June 13, 2019 23:59
FCBH-123 Implement @react-native-community/viewpager
Copy link
Copy Markdown

@ahanriat ahanriat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceBT
Copy link
Copy Markdown

VinceBT commented Jun 27, 2019

@zbtang merge this in a new major version please

@shercoder
Copy link
Copy Markdown

@zbtang would love to get this merged so people can start using this as soon as possible and before RN marks ViewPagerAndroid obsolete from their repo. 🙏

@shercoder
Copy link
Copy Markdown

@mgonzalezs At Build.com, we have forked this lib so we can update it to use the RNCViewPager. Would you like to submit this PR to https://github.com/buildcom/React-Native-ViewPager and I can get it merged.

@mgonzalezs
Copy link
Copy Markdown
Author

@shercoder done! ;)

@shercoder
Copy link
Copy Markdown

@shercoder done! ;)

@mgonzalezs Thank you so much. I have merged it and released a new tag v2.0.0 https://github.com/buildcom/React-Native-ViewPager/releases/tag/2.0.0

Feel free to use it :)

@Alarees
Copy link
Copy Markdown

Alarees commented Aug 6, 2019

@shercoder a'm new to git how to use this tag
i have download the 'zip' file and in demo the 'rn-viewpager' version is '^1.2.4', it's old
how to use this Implementation ?

@shercoder
Copy link
Copy Markdown

@Alarees Please use forked version of this lib here https://github.com/buildcom/React-Native-ViewPager

In your package.json, add this under dependencies:
"rn-viewpager": "github:buildcom/React-Native-ViewPager#2.0.0"
and then run npm install

Then follow the rest of the instructions from the README to integrate it into your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants