Disable SamplingProfilerTest.HeapSnapshot on macOS#31024
Open
ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
Open
Disable SamplingProfilerTest.HeapSnapshot on macOS#31024ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
Conversation
gperftools heap profiling is unreliable on macOS arm64: stack unwinding only captures internal allocator frames (depth=1), and freed allocations persist in heap snapshots returned by ReadStackTraces.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the HeapSnapshot test on macOS due to reliability issues with gperftools heap profiling on arm64 architectures. The review feedback suggests using a more targeted disabling mechanism if the test is stable on x86_64 and recommends including a link to a tracking issue for the platform-specific failure.
Contributor
|
trigger jenkins |
Contributor
|
Phorge diff synced: D51953 Jenkins build has been triggered. Results will be posted here once it completes. JenkinsBot |
Contributor
|
✅ Jenkins build for commit Passed: 9 🔨 DB Build/Test Job Summary
JenkinsBot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gperftools heap profiling is unreliable on macOS arm64: stack unwinding
only captures internal allocator frames (depth=1), and freed allocations
persist in heap snapshots returned by ReadStackTraces.
Phorge: D51953