Skip xcluster DDL replication tests requiring yb-controller on macOS#31002
Merged
iSignal merged 1 commit intoyugabyte:masterfrom Apr 20, 2026
Merged
Skip xcluster DDL replication tests requiring yb-controller on macOS#31002iSignal merged 1 commit intoyugabyte:masterfrom
iSignal merged 1 commit intoyugabyte:masterfrom
Conversation
…ot available on macOS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the VectorIndexLateWriteAfterBackfillMissing test in xcluster_ddl_replication-test.cc to skip execution when yb-controller is not used, as the test is incompatible with yb_backup.py. I have no feedback to provide.
Contributor
|
trigger jenkins |
Contributor
|
Phorge diff synced: D52188 Jenkins build has been triggered. Results will be posted here once it completes. JenkinsBot |
Contributor
|
@ellabaron-code : looks good to me, will accept after double checking unit tests |
Contributor
|
✅ Jenkins build for commit Passed: 9 🔨 DB Build/Test Job Summary
JenkinsBot |
iSignal
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yb-controller-serveris a pre-built binary only available on Linux.Tests that set
start_yb_controller_servers = truecrash on macOS because the binary doesn't exist.All the tests in
XClusterDDLReplicationTesttest suite that requireyb-controller-server, perform a check if this executable is available. The test is skipped then, if it is not available.This check was omitted for
VectorIndexLateWriteAfterBackfillMissingtest case and it was failing on macOS. This PR provides a fix for this failure.Phorge: D52188