Skip to content

[Docs] Hide extra scroll bar from the code snippets#30948

Open
samiahmedsiddiqui wants to merge 2 commits intoyugabyte:masterfrom
samiahmedsiddiqui:fix/scroll-bar-code-snippets
Open

[Docs] Hide extra scroll bar from the code snippets#30948
samiahmedsiddiqui wants to merge 2 commits intoyugabyte:masterfrom
samiahmedsiddiqui:fix/scroll-bar-code-snippets

Conversation

@samiahmedsiddiqui
Copy link
Copy Markdown
Contributor

@netlify /stable/releases/yugabyte-clients/

inline-tabs

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 2, 2026

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 352ed1a
🔍 Latest deploy log https://app.netlify.com/projects/infallible-bardeen-164bc9/deploys/69cf76cb938f620008518e19
😎 Deploy Preview https://deploy-preview-30948--infallible-bardeen-164bc9.netlify.app/stable/releases/yugabyte-clients/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the SCSS for code blocks to set the overflow property to visible for pre elements. A review comment points out that the current implementation nests this rule within a comma-separated selector, which generates an unintended CSS selector (pre pre). The feedback suggests isolating the rule to target .highlight pre specifically to avoid this issue.

Comment thread docs/assets/scss/_code_block.scss Outdated
Comment on lines 79 to 82
pre{
overflow: visible;
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This nested rule is inside a comma-separated selector (> pre, .highlight), which will cause the generated CSS to be .td-content > pre pre, .td-content .highlight pre. The first selector, .td-content > pre pre, targets a pre element inside another pre element and is likely unintended. To ensure this style only applies to pre elements within .highlight, this rule should be moved out of this shared block and defined separately for .highlight.

Suggested change
pre{
overflow: visible;
}
}
}
.highlight pre {
overflow: visible;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant