Skip to content

Fix parallel ctest runs sharing the same TEST_TMPDIR#30904

Merged
rahulb-yb merged 1 commit intoyugabyte:masterfrom
Shopify:build-script-ctest-fix
Apr 14, 2026
Merged

Fix parallel ctest runs sharing the same TEST_TMPDIR#30904
rahulb-yb merged 1 commit intoyugabyte:masterfrom
Shopify:build-script-ctest-fix

Conversation

@ellabaron-code
Copy link
Copy Markdown
Collaborator

@ellabaron-code ellabaron-code commented Mar 31, 2026

yb_build.sh was calling ensure_test_tmp_dir_is_set() before launching
ctest, which exported TEST_TMPDIR with yb_build.sh's own PID into the
environment. All parallel run-test.sh processes spawned by ctest
inherited this value and skipped creating their own unique directories,
causing them to clobber each other's temp files mid-test.

The call is unnecessary since run-test.sh calls ensure_test_tmp_dir_is_set()
itself, creating a unique directory per process.


Phorge: D51698

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the call to ensure_test_tmp_dir_is_set within the local test execution block in yb_build.sh. I have no feedback to provide.

@hari90
Copy link
Copy Markdown
Contributor

hari90 commented Apr 1, 2026

Trigger Jenkins

@hari90
Copy link
Copy Markdown
Contributor

hari90 commented Apr 1, 2026

Phorge diff synced: D51698
Commit: b3a52bc0

Jenkins build has been triggered. Results will be posted here once it completes.

@hari90
Copy link
Copy Markdown
Contributor

hari90 commented Apr 1, 2026

Jenkins build for commit b3a52bc0: Fail

Exceptions:


🚫 Failed Landing Requirements

'Multi-Build Test Failures' failed


🔨 DB Build/Test Job Summary

Build Total Passed Failed Failed After Retries
D51698-alma8-clang21-tsan 1 0 1 1
D51698-arm-mac14-clang-release 1 0 1 1
D51698-mac14-clang-release 1 0 1 1
D51698-arm-alma8-clang21-release 1 0 1 1
D51698-alma9-clang21-asan 1 0 1 1
D51698-alma8-clang21-release 1 0 1 1
D51698-ubuntu22.04-clang21-debug 1 0 1 1
D51698-alma8-gcc12-fastdebug 1 0 1 1

Full status

yb_build.sh was calling ensure_test_tmp_dir_is_set() before launching
ctest, which exported TEST_TMPDIR with yb_build.sh's own PID into the
environment. All parallel run-test.sh processes spawned by ctest
inherited this value and skipped creating their own unique directories,
causing them to clobber each other's temp files mid-test.

The call is unnecessary since run-test.sh calls ensure_test_tmp_dir_is_set()
itself, creating a unique directory per process.
@ellabaron-code ellabaron-code force-pushed the build-script-ctest-fix branch from b3a52bc to e61af25 Compare April 6, 2026 16:22
@rahulb-yb
Copy link
Copy Markdown
Contributor

Trigger Jenkins

@hari90
Copy link
Copy Markdown
Contributor

hari90 commented Apr 6, 2026

Phorge diff synced: D51698
Commit: e61af25b

Jenkins build has been triggered. Results will be posted here once it completes.


JenkinsBot

@hari90
Copy link
Copy Markdown
Contributor

hari90 commented Apr 6, 2026

Jenkins build for commit e61af25b: Pass

Passed: 9


🔨 DB Build/Test Job Summary

Build Total Passed Failed Failed After Retries
D51698-ubuntu22.04-clang21-debug 2 2 0 0
D51698-mac14-clang-release 2 2 0 0
D51698-alma9-clang21-asan 2 2 0 0
D51698-alma8-clang21-release 2 2 0 0
D51698-alma8-clang21-tsan 2 2 0 0
D51698-arm-alma8-clang21-release 2 2 0 0
D51698-arm-mac14-clang-release 2 2 0 0
D51698-alma8-gcc12-fastdebug 2 2 0 0

Full status


JenkinsBot

@rahulb-yb rahulb-yb merged commit eb1d166 into yugabyte:master Apr 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants