Optimize alt linking to avoid redundant operations (fixes #236)#538
Open
slowsage wants to merge 1 commit intoyadm-dev:developfrom
Open
Optimize alt linking to avoid redundant operations (fixes #236)#538slowsage wants to merge 1 commit intoyadm-dev:developfrom
slowsage wants to merge 1 commit intoyadm-dev:developfrom
Conversation
863a61e to
b3ac902
Compare
Tests: yadm-dev#65 (test_stale_link_removal) still passes. yadm-dev#236 (test_alt_preserves_user_symlink_until_alt_tracked) lazy touch (test_alt_skips_correct_symlink_without_touching)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change reduces unnecessary filesystem operations and preserves user‑created symlinks when no alternate is tracked. Stale links are still removed (#236). Added two tests. #65 still passes.
What issues does this PR fix or reference?
#236
Previous Behavior
#236
Touch only when necessary:
New Behavior
#236
Touch only when necessary
Have tests been written for this change?
Yes
Have these commits been signed with GnuPG?
Yes
Please review yadm's Contributing Guide for best practices.