Open
Conversation
dimbleby
force-pushed
the
type-checking
branch
from
e0b884d to
3f428d0
Compare
and include py.typed in the published packages so that consumers can make use of the types
dimbleby
force-pushed
the
type-checking
branch
from
3f428d0 to
fe5f73f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi -
I used this library on a project recently and it worked great, mostly I'm just here to say thanks for that.
As a token of that gratitude I did a little work to complete the type-checking in this codebase: and also to include py.typed in the published packages so that consumers of the library can make use of those types.
I see that this project is largely inactive - I guess it's basically "done". If you feel like merging this, great: but if you don't see it or don't care for it for whatever reason then no problem - this was little enough work for me that I won't mind at all.
Cheers!