Skip to content

chore: improve memory management for partially created mux#2995

Draft
Noroth wants to merge 3 commits into
ludwig/otel-fixesfrom
ludwig/eng-9793-router-partial-graph-mux-failure-causes-memory-leak
Draft

chore: improve memory management for partially created mux#2995
Noroth wants to merge 3 commits into
ludwig/otel-fixesfrom
ludwig/eng-9793-router-partial-graph-mux-failure-causes-memory-leak

Conversation

@Noroth

@Noroth Noroth commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

WIP

@coderabbitai summary

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9e461585-1fb4-4533-a671-019eb6742649

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-24e17f4d2478ed9c8354a0b50efcc76e151da1e3

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.40%. Comparing base (91268ec) to head (9e98e9e).

Files with missing lines Patch % Lines
router/core/graph_server.go 64.70% 3 Missing and 3 partials ⚠️
router/pkg/metric/cache_metrics.go 0.00% 1 Missing ⚠️
router/pkg/metric/engine_metrics.go 0.00% 1 Missing ⚠️
router/pkg/metric/otlp_metric_store.go 0.00% 1 Missing ⚠️
router/pkg/metric/prom_connection_metric_store.go 0.00% 1 Missing ⚠️
router/pkg/metric/router_runtime_metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           ludwig/otel-fixes    #2995      +/-   ##
=====================================================
+ Coverage              61.20%   61.40%   +0.20%     
=====================================================
  Files                    259      259              
  Lines                  30039    30054      +15     
=====================================================
+ Hits                   18385    18456      +71     
+ Misses                 10158    10114      -44     
+ Partials                1496     1484      -12     
Files with missing lines Coverage Δ
router/pkg/metric/cache_metrics.go 85.84% <0.00%> (ø)
router/pkg/metric/engine_metrics.go 75.90% <0.00%> (ø)
router/pkg/metric/otlp_metric_store.go 81.25% <0.00%> (ø)
router/pkg/metric/prom_connection_metric_store.go 83.33% <0.00%> (ø)
router/pkg/metric/router_runtime_metrics.go 76.38% <0.00%> (ø)
router/core/graph_server.go 85.26% <64.70%> (+0.15%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant