Fix DH encoding check in wolfSSL_CTX_set_tmp_dh: && to || and < to <= to catch single-param failure and zero-length, matching wolfSSL_set_tmp_dh.

night1rider · night1rider · commit 5003c033eb83 · 2026-04-07T13:00:09.000-06:00
diff --git a/src/ssl_load.c b/src/ssl_load.c
@@ -5864,7 +5864,7 @@ long wolfSSL_CTX_set_tmp_dh(WOLFSSL_CTX* ctx, WOLFSSL_DH* dh)
         pSz = wolfSSL_BN_bn2bin(dh->p, p);
         gSz = wolfSSL_BN_bn2bin(dh->g, g);
         /* Check encoding worked. */
-        if ((pSz < 0) && (gSz < 0)) {
+        if ((pSz <= 0) || (gSz <= 0)) {
             ret = WOLFSSL_FATAL_ERROR;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -5864,7 +5864,7 @@ long wolfSSL_CTX_set_tmp_dh(WOLFSSL_CTX* ctx, WOLFSSL_DH* dh)`
`5864`	`5864`	`pSz = wolfSSL_BN_bn2bin(dh->p, p);`
`5865`	`5865`	`gSz = wolfSSL_BN_bn2bin(dh->g, g);`
`5866`	`5866`	`/* Check encoding worked. */`
`5867`		`- if ((pSz < 0) && (gSz < 0)) {`
	`5867`	`+ if ((pSz <= 0) \|\| (gSz <= 0)) {`
`5868`	`5868`	`ret = WOLFSSL_FATAL_ERROR;`
`5869`	`5869`	`}`
`5870`	`5870`	`}`