Fix == vs = in wolfSSL_add1_chain_cert so ret captures up_ref result instead of comparing against it, matching wolfSSL_CTX_add1_chain_cert

night1rider · night1rider · commit 939f978bb302 · 2026-04-07T12:40:32.000-06:00
diff --git a/src/ssl_load.c b/src/ssl_load.c
@@ -5202,7 +5202,7 @@ int wolfSSL_add1_chain_cert(WOLFSSL* ssl, WOLFSSL_X509* x509)
     }
 
     /* Increase reference count on X509 object before adding. */
-    if ((ret == 1) && ((ret == wolfSSL_X509_up_ref(x509)) == 1)) {
+    if ((ret == 1) && ((ret = wolfSSL_X509_up_ref(x509)) == 1)) {
         /* Add this to the chain. */
         if ((ret = wolfSSL_add0_chain_cert(ssl, x509)) != 1) {
             /* Decrease reference count on error as not stored. */

Original file line number	Diff line number	Diff line change
`@@ -5202,7 +5202,7 @@ int wolfSSL_add1_chain_cert(WOLFSSL* ssl, WOLFSSL_X509* x509)`
`5202`	`5202`	`}`
`5203`	`5203`
`5204`	`5204`	`/* Increase reference count on X509 object before adding. */`
`5205`		`- if ((ret == 1) && ((ret == wolfSSL_X509_up_ref(x509)) == 1)) {`
	`5205`	`+ if ((ret == 1) && ((ret = wolfSSL_X509_up_ref(x509)) == 1)) {`
`5206`	`5206`	`/* Add this to the chain. */`
`5207`	`5207`	`if ((ret = wolfSSL_add0_chain_cert(ssl, x509)) != 1) {`
`5208`	`5208`	`/* Decrease reference count on error as not stored. */`