fix(cloudflare): add namespace filter to astro-frontmatter-scan esbuild plugin#16272
Open
barry3406 wants to merge 2 commits intowithastro:mainfrom
Open
fix(cloudflare): add namespace filter to astro-frontmatter-scan esbuild plugin#16272barry3406 wants to merge 2 commits intowithastro:mainfrom
barry3406 wants to merge 2 commits intowithastro:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16203
Problem
The
astro-frontmatter-scanesbuild plugin registers itsonLoadhandler without anamespacefilter. In esbuild, an unfilteredonLoadmatches all namespaces, includinghtml. When a.tsfile default-imports an.astrocomponent, Vite's dep scanner resolves the.astrofile into thehtmlnamespace. The plugin intercepts it and returns only the extracted frontmatter — which has noexport default— causing:Fix
Add
namespace: 'file'to theonLoadcall so the plugin only handles.astrofiles resolved from the filesystem. Files in thehtmlnamespace now fall through to Vite's built-inhtmlTypeOnLoadCallback, which already appendsexport default {}for non-.vuefiles.Test plan
filenamespace behavior is unchanged — same handler, same logic, only the namespace scope is narrowed