chore: port unit tests to TypeScript#16255
Conversation
|
github-actions
Bot
added
the
pkg: astro
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Thank you. I can see an agent at play here, which did some lazy work just to make the system happy. Please fix those parts
| scripts: new Set(), | ||
| links: new Set(), | ||
| }; | ||
| } as unknown as SSRResult; |
There was a problem hiding this comment.
It's evident you're using AI. Tell your agent to not be lazy. This is a workaround to make the system happy. This function must declare all mandatory fields now
| let output = ''; | ||
| const destination = { | ||
| write(chunk) { | ||
| write(chunk: unknown) { |
| // Create a simple component | ||
| const componentInstance = { | ||
| render(dest) { | ||
| render(dest: { write(chunk: unknown): void }) { |
| }, | ||
| }, | ||
| }; | ||
| } as unknown as StaticPathsApp; |
There was a problem hiding this comment.
This file would need the helpers, and the types you added are incorrect. Maybe let's revert it for now
- queue-batching.test.ts: declare all mandatory SSRResult fields instead of using `as unknown as SSRResult` workaround, use RenderDestination and RenderDestinationChunk types for destination objects - static-paths.test: revert back to .js since it needs shared helpers and the types were incorrect
|
That's done. Thank you |
2 participants
Changes
Part of #16241
Ports 7 self-contained unit test files from JavaScript to TypeScript.
Files ported:
assets/remote.testi18n/i18n-utils.testremote-pattern.testrender/queue-batching.testrender/queue-pool.testrender/transitions.testrouting/generator.testThese files were chosen because they don't depend on shared JS test helpers (
mocks.js,test-utils.js), so they can be ported independently without creating mixed JS/TS helper conflicts.Changes beyond the rename:
// @ts-checkdirectives (redundant in.tsfiles)@param/@returnsto native TS types where neededSSRResultfields in thequeue-batching.test.tsmock (following the pattern inserver-islands-render.test.ts)RenderDestinationandRenderDestinationChunkfor destination objects inqueue-batching.test.tsLocalestype annotation for mixed locale arrays ini18n-utils.test.tstrailingSlashtoAstroConfig['trailingSlash']ingenerator.test.ts.hrefon URL objects passed toisRemoteAllowedinremote-pattern.test.tsNo changeset — test-only changes with no user-facing impact.
Testing
typecheck:tests,test:unit:ts, andtest:unit:jsall pass with zero failures.Docs
No docs needed — internal test migration only.