fix: Fix accounts merge#162
Open
zengxu-yang wants to merge 3 commits into
Open
Conversation
zengxu-yang
force-pushed
the
fix_accounts_merge
branch
2 times, most recently
from
5aae7d7 to
772ef97
Compare
Owner
|
Hi, thank you for your contribution. Please also update the JSON that is where the resource for cli to generate the files. Otherwise, cli will just generate the old code. I think I will add CI/CD to check consistent later with the code and JSONs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed an incorrect problem set in Problem 721.
Move the sorting process to two_sum/helpers.py to be consistent with other problems.
Why?
The pytest problem set of Problem 721 contains a mistake that prevents it from passing the tests.