Skip to content

feat: UI for promoting next user to admin role (WPB-25278)#4819

Open
sbakhtiarov wants to merge 1 commit into
developfrom
feat/promote-user-admin-ui
Open

feat: UI for promoting next user to admin role (WPB-25278)#4819
sbakhtiarov wants to merge 1 commit into
developfrom
feat/promote-user-admin-ui

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 13, 2026

https://wearezeta.atlassian.net/browse/WPB-25278

https://wearezeta.atlassian.net/browse/WPB-25278

What's new in this PR?

New dialog for leave conversation options and screen for selecting next admin user.

Screen_recording_20260513_090643.webm

@github-actions
Copy link
Copy Markdown
Contributor

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.14%. Comparing base (0bb1fbf) to head (9770588).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...i/home/conversationslist/model/GroupDialogState.kt 0.00% 5 Missing ⚠️
...onversations/promoteadmin/PromoteAdminViewModel.kt 85.71% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4819      +/-   ##
===========================================
+ Coverage    51.11%   51.14%   +0.03%     
===========================================
  Files          610      611       +1     
  Lines        21091    21124      +33     
  Branches      3392     3397       +5     
===========================================
+ Hits         10780    10804      +24     
- Misses        9299     9306       +7     
- Partials      1012     1014       +2     
Files with missing lines Coverage Δ
...onversations/promoteadmin/PromoteAdminViewModel.kt 85.71% <85.71%> (ø)
...i/home/conversationslist/model/GroupDialogState.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb1fbf...9770588. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov force-pushed the feat/promote-user-admin-ui branch from 3e04c2b to 9770588 Compare May 13, 2026 12:53
@sbakhtiarov sbakhtiarov requested a review from saleniuk May 13, 2026 12:53
@github-actions
Copy link
Copy Markdown
Contributor

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69a608d5126385b2a1284845657c0bbf11f9c65 c7bc36514a75f7398e0f7f85a981561ec1fb023a

Is this intentional?

@sonarqubecloud
Copy link
Copy Markdown

get() = if (searchQuery.isBlank()) {
allMembers
} else {
allMembers.filter { it.name.contains(searchQuery, ignoreCase = true) }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also consider handle ?

allMembers.filter {
    it.name.contains(searchQuery, true) ||
    it.handle.contains(searchQuery, true)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants