Fix Python 3.14 compatibility and simulation bugs#112
Open
adjenk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This wasn't working for me with python 3.14; I was getting IndentationErrors. That was because it didn't like the way the docstrings were indented.
The is_epidemic_over loop was missing event handling so I added pygame.event.get() loop to drain events each frame and handle the QUIT event. The other part of this issue was that in is_epidemic_over(self) we were using is instead of == to compare the integer constant with 0, so it seemed like the epidemic never ended.
The progress_healing() method decremented remaining_recovery but it was never setting the Recovered state for hosts with no remaining recovery time.