Drop usage of fs-extra and switch to native fs#608
Merged
Conversation
Member
|
It would be also nice to drop it in website-scraper-existing-directory |
Replace fs-extra with native fs in all test files:
- fs.removeSync(dir) -> fs.rmSync(dir, {recursive: true, force: true})
- fs.mkdirpSync(dir) -> fs.mkdirSync(dir, {recursive: true})
- fs.emptyDirSync(dir) -> fs.rmSync + fs.mkdirSync
Remove fs-extra from devDependencies as it is no longer used.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keeps the error-action cleanup non-blocking, matching the original awaited fs.remove behavior and the async outputFile write path. The error action runs at most once (single catch in Scraper.scrape), so the async call carries no concurrency risk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs-extrahas been fully removed fromdependencies/devDependencies. All test files now use nativefs:fs.removeSync(dir)→fs.rmSync(dir, {recursive: true, force: true})fs.mkdirpSync(dir)→fs.mkdirSync(dir, {recursive: true})fs.emptyDirSync(dir)→fs.rmSync(...)+fs.mkdirSync(...)