chore: finish converting load_nft.rs to arlog_*! macros (PR 2/4 for #90)#113
Merged
kalwalt merged 1 commit intowebarkit:devfrom May 7, 2026
Merged
Conversation
Completes the conversion of crates/core/examples/load_nft.rs from a half-converted state (22 remaining println! calls alongside 1 existing arlog_i!) to uniform arlog_*! usage. CLAUDE.md §2 names load_nft.rs as the canonical example for newcomers, so getting this consistent matters beyond the mechanical cleanup. All 22 sites classified as arlog_i!, including four inside bounded enumeration loops (pyramid scales, pages, image lists). The loops are one-shot enumerations of loaded NFT data with N ~1-10, not per-frame detection paths -- matching the PR 1 precedent in debug_labeling.rs where a take(10) enumeration loop also uses arlog_i!. Trailing \n stripped from four format strings per the established convention (the log backend handles line structure). Imports and Cargo.toml unchanged -- the existing use webarkitlib_rs::arlog_i; and the existing [[example]] block already cover this PR. Part 2 of 4 for webarkit#90.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 4 for #90 Finishes the conversion of crates/core/examples/load_nft.rs to arlog_*! macros — the file was previously half-converted (logger init + one arlog_i! call existed alongside 22 remaining println! calls). CLAUDE.md §2 names this file as the canonical example for newcomers, so getting it consistent matters beyond the mechanical cleanup.
Scope
No other files touched. Existing import and Cargo.toml [[example]] block already cover this PR.
Classification note
All 22 sites are arlog_i!, including four inside bounded enumeration loops (pyramid scales, pages, image lists). The loops iterate over already-loaded NFT data with N ~1–10, not per-frame detection paths — matching the PR 1 precedent in debug_labeling.rs:92-97 where a take(10) enumeration loop also uses arlog_i!. Happy to revisit if you'd prefer arlog_d! for the loop bodies.
Verification
Skipped per pre-existing issues already documented on the issue thread: cargo build --all-features (macOS stdc++) and cargo clippy --all-targets -- -D warnings (lib-side doctest lint).